Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update app service instance query and fix typo #554

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

ibersanoMS
Copy link
Contributor

@ibersanoMS ibersanoMS commented Dec 6, 2024

Overview/Summary

  • Fixed App Service query to return the correct number of instances

Related Issues/Work Items

#508

Breaking Changes

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings December 6, 2024 22:09
@ibersanoMS ibersanoMS requested a review from a team as a code owner December 6, 2024 22:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Dec 6, 2024
@ibersanoMS
Copy link
Contributor Author

ARG Query - App Service Instance Count

Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ibersanoMS. Since the query now returns the microsoft.web/serverFarms resource type we'll need to update the recommendationResourceType in the yaml file and we should move the recommendation to the appropriate section in APRL. Recommendation's resources matching the recommendation resource type is a requirement for the new resource targeting feature coming to workload reviews in Advisor.

Let me know if you have any questions about these additional changes.

@ejhenry ejhenry added the Area: Resource Graph Query(s) #️⃣ Related to ARG queries label Dec 6, 2024
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ibersanoMS

@ejhenry ejhenry requested a review from oZakari December 10, 2024 23:29
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 37b3419 into Azure:main Dec 12, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants