-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update app service instance query and fix typo #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ibersanoMS. Since the query now returns the microsoft.web/serverFarms resource type we'll need to update the recommendationResourceType in the yaml file and we should move the recommendation to the appropriate section in APRL. Recommendation's resources matching the recommendation resource type is a requirement for the new resource targeting feature coming to workload reviews in Advisor.
Let me know if you have any questions about these additional changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @ibersanoMS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Related Issues/Work Items
#508
Breaking Changes
As part of this pull request I have
main
branch