Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sql mi changes #457

Merged
merged 16 commits into from
Oct 17, 2024
Merged

feat: Sql mi changes #457

merged 16 commits into from
Oct 17, 2024

Conversation

ramyerrabotu
Copy link
Contributor

@ramyerrabotu ramyerrabotu commented Oct 9, 2024 •
edited by oZakari
Loading

Overview/Summary

Added review comments provided by SQL MI PG team for SQL MI APRL.

image

image

image

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ramyerrabotu ramyerrabotu requested review from a team as code owners October 9, 2024 10:57
@kpoineal
Copy link
Contributor

kpoineal commented Oct 9, 2024

@ramyerrabotu Can you please fill out the Pull request template? I see that you're working on SQL MI but there's some checks that are failing and we need to know what the PR is intended to do.

@oZakari oZakari added Area: Resource Graph Query(s) #️⃣ Related to ARG queries Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Oct 10, 2024
@oZakari
Copy link
Collaborator

oZakari commented Oct 16, 2024

@ramyerrabotu, please also include screenshots of the outputs of your queries in your form as well.

@oZakari oZakari added the Area: Resource Guidance 📝 Improvements or additions to documentation label Oct 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Oct 16, 2024
@ramyerrabotu ramyerrabotu changed the title Sql mi changes2 feat: Sql mi changes Oct 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Oct 16, 2024
@oZakari oZakari requested a review from a team as a code owner October 16, 2024 17:10
@kpoineal
Fix: ppt template
fcb48ac 
Fix: sample output
oZakari
oZakari approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ramyerrabotu!

@oZakari oZakari requested a review from a team October 17, 2024 03:24
@oZakari oZakari added the Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. label Oct 17, 2024
@kpoineal kpoineal merged commit a44f39b into main Oct 17, 2024
10 checks passed
@kpoineal kpoineal deleted the SQL-MI-changes2 branch October 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpoineal kpoineal kpoineal approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramyerrabotu @kpoineal @oZakari