Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve KQL stability for resource group recommendation #454

Merged
merged 9 commits into from
Oct 10, 2024
Merged

fix: Improve KQL stability for resource group recommendation #454

merged 9 commits into from
Oct 10, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Oct 9, 2024

Overview/Summary

Improved the KQL stability for the resource group recommendation "Ensure Resource Group and its Resources are located in the same Region".

Related Issues/Work Items

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Screenshot

image

@tksh164 tksh164 requested a review from a team as a code owner October 9, 2024 01:25
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Oct 9, 2024
ejhenry
ejhenry approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @tksh164!

@ejhenry ejhenry requested a review from a team October 9, 2024 16:13
@oZakari oZakari merged commit 31b7f11 into Azure:main Oct 10, 2024
7 checks passed
@tksh164 tksh164 deleted the fix/issue-406 branch October 10, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Bug 🐞 Something isn't working Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - KQL For resourceGroups is not working
3 participants
@tksh164 @oZakari @ejhenry