Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: AVD guidance updates #432

Merged
merged 14 commits into from
Oct 9, 2024
Merged

docs: AVD guidance updates #432

merged 14 commits into from
Oct 9, 2024

Conversation

danycontre
Copy link
Contributor

Overview/Summary

  • Updating AVD guidance items semantics.
  • Removing route table item since it wasn't providing real guidance.
  • Adding two new items for compute gallery image versions guidance.

Related Issues/Work Items

NA

Examples:
NA

Breaking Changes

  1. None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@danycontre danycontre requested review from a team as code owners September 24, 2024 15:03
@danycontre
Copy link
Contributor Author

@swathibhat1 @moisesjgomez

@danycontre danycontre changed the title Docs: AVD guidance updates docs: AVD guidance updates Sep 24, 2024
@danycontre danycontre added Bug 🐞 Something isn't working Area: Resource Guidance 📝 Improvements or additions to documentation labels Sep 24, 2024
@oZakari
Copy link
Collaborator

oZakari commented Sep 24, 2024

Hey @danycontre, could you take a look at the yaml schema linter errors and resolve?

@github-actions github-actions bot requested a review from a team as a code owner September 25, 2024 00:35
@oZakari oZakari requested a review from a team September 30, 2024 17:19
@oZakari oZakari added Needs: Attention from aprl-avd 👋 Needs attention from aprl-avd GitHub team. Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Sep 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Oct 9, 2024
@danycontre
Copy link
Contributor Author

@oZakari please let me know if anything else is pending.

oZakari
oZakari previously approved these changes Oct 9, 2024
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) October 9, 2024 17:46
@danycontre danycontre requested a review from swathibhat1 October 9, 2024 18:52
@oZakari oZakari requested a review from a team October 9, 2024 18:52
@danycontre
Copy link
Contributor Author

@moisesjgomez @swathibhat1 please review this PR.

swathibhat1
swathibhat1 approved these changes Oct 9, 2024
View reviewed changes
Copy link

@swathibhat1 swathibhat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 0f37eed into Azure:main Oct 9, 2024
8 checks passed
moisesjgomez
moisesjgomez reviewed Oct 9, 2024
View reviewed changes
azure-resources/DesktopVirtualization/hostPools/recommendations.yaml
@@ -24,7 +24,7 @@
recommendationResourceType: Microsoft.DesktopVirtualization/hostPools
recommendationMetadataState: Active
longDescription: |
Create maintenance schedules for AVD agent updates to avoid disruptions. Use Scheduled Agent Updates to set maintenance windows for updating Azure Virtual Desktop agent, side-by-side stack, and Geneva Monitoring agent.
Create up to two maintenance windows for the Azure Virtual Desktop agent, side-by-side stack, and Geneva Monitoring agent to get updated so that updates don't happen during peak business hours.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, small rewrite:

Configure up to two maintenance windows for updating the Azure Virtual Desktop agent, side-by-side stack, and Geneva Monitoring agent, ensuring that these updates occur outside of peak business hours.

azure-resources/DesktopVirtualization/hostPools/recommendations.yaml
@@ -42,7 +42,7 @@
recommendationResourceType: Microsoft.DesktopVirtualization/hostPools
recommendationMetadataState: Active
longDescription: |
For optimized AVD configuration, place Hybrid VMs in unique OUs. Segregate Prod and DR units for environment-specific settings. This ensures targeted configurations for session hosts, including FSLogix, timeouts, and session controls.
Place domain joined session hosts VMs in unique OUs. Segregate Prod and DR units for environment-specific settings. This ensures targeted configurations for session hosts, including FSLogix, session controls, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, small rewrite:

Segregate Prod and DR units into unique Organizational Units (OU) for environment-specific settings, ensuring targeted configurations for session hosts including FSLogix, session controls, etc.

azure-resources/VirtualMachineImages/imageTemplates/recommendations.yaml
@@ -24,14 +24,14 @@
recommendationResourceType: Microsoft.VirtualMachineImages/imageTemplates
recommendationMetadataState: Active
longDescription: |
The Azure Image Builder service, used for deploying Image Templates, lacks availability zones support. By replicating Image Templates to a secondary, preferably paired, region, quick recovery from a region failure is enabled, ensuring continuous virtual machine deployment from these templates.
The Azure Image Builder service lacks availability zones support. Replicating Image Templates to a secondary region will enable the build of new images in secondary region.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't make sense to me.

First sentence mentioned lack of AZ support and second sentence refers to secondary region.

Might make sense to have something closer to:

The Azure Image Builder Service is a regional service. Replicate Image Templates to a secondary region to enable build of new images in secondary region if/when required.

Though guid b14ee8ed-7d27-447b-b6fb-6472cb5f4b75 says something similar as well, we may remove this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moisesjgomez moisesjgomez moisesjgomez left review comments

@swathibhat1 swathibhat1 swathibhat1 approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Auto-Merge ✔️ Bug 🐞 Something isn't working Needs: Attention from aprl-avd 👋 Needs attention from aprl-avd GitHub team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danycontre @oZakari @moisesjgomez @swathibhat1