Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add fence for non-supported operating systems #274

Merged
merged 26 commits into from
Aug 15, 2024
Merged

feat: Add fence for non-supported operating systems #274

merged 26 commits into from
Aug 15, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jul 12, 2024

Overview/Summary

Added fences for non-supported operating systems.

macOS (Sonoma 14.5):
image

Linux (Ubuntu 24.04):
image

Related Issues/Work Items

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@tksh164 tksh164 requested a review from a team as a code owner July 12, 2024 14:31
oZakari
oZakari previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@oZakari oZakari added Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team Area: Tools 🧰 Related to the tools directory and/or content labels Jul 12, 2024
@oZakari oZakari requested a review from a team July 12, 2024 16:01
@kpoineal
Copy link
Contributor

Thank you! I've approved this but we will need the rest of the team to do so as well.

@tksh164 tksh164 changed the title Add fence for non-supported operating systems feat: Add fence for non-supported operating systems Jul 24, 2024
@tksh164
Copy link
Member Author

tksh164 commented Aug 1, 2024

@caseywatson @Claudio-Merola Would you be willing to review this PR? This PR has been over 3 weeks with no reviews. Thanks.

@tksh164 tksh164 merged commit 4c63ff8 into Azure:main Aug 15, 2024
4 checks passed
@tksh164 tksh164 deleted the add-platform-check branch August 15, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpoineal kpoineal kpoineal approved these changes

@oZakari oZakari oZakari approved these changes

Assignees

@caseywatson caseywatson

@Claudio-Merola Claudio-Merola

Labels
Area: Tools 🧰 Related to the tools directory and/or content Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Create notification of limitation to run on Windows
5 participants
@tksh164 @kpoineal @oZakari @caseywatson @Claudio-Merola