Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve recommendation sheet cell formats #268

Merged
merged 23 commits into from
Aug 15, 2024
Merged

feat: Improve recommendation sheet cell formats #268

merged 23 commits into from
Aug 15, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jul 11, 2024 •
edited by oZakari
Loading

Overview/Summary

Changed text alignment to improve the readability of the Recommendation sheet in the Action Plan Excel file that is generated by the 2_wara_data_analyzer.ps1 script.

Related Issues/Work Items

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@tksh164 tksh164 requested a review from a team as a code owner July 11, 2024 07:23
oZakari
oZakari previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement👍🏼

@oZakari oZakari requested a review from a team July 11, 2024 19:17
@oZakari oZakari added Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team Area: Tools 🧰 Related to the tools directory and/or content labels Jul 11, 2024
@tksh164 tksh164 changed the title Improve recommendation sheet cell formats feat: Improve recommendation sheet cell formats Jul 24, 2024
@tksh164
Copy link
Member Author

tksh164 commented Aug 1, 2024

@caseywatson @kpoineal @Claudio-Merola Would you be willing to review this PR? This PR has been over 3 weeks with no reviews. Thanks.

@tksh164 tksh164 merged commit f767345 into Azure:main Aug 15, 2024
4 checks passed
@tksh164 tksh164 deleted the improve-excel-recommendation-sheet branch August 15, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Claudio-Merola Claudio-Merola Claudio-Merola approved these changes

@oZakari oZakari oZakari approved these changes

Assignees

@caseywatson caseywatson

@kpoineal kpoineal

@Claudio-Merola Claudio-Merola

Labels
Area: Tools 🧰 Related to the tools directory and/or content Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Text alignment in Recommendation sheet in Action Plan Excel file
5 participants
@tksh164 @oZakari @Claudio-Merola @caseywatson @kpoineal