Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix duplicated "Microsoft." in resource type in output messages #262

Merged
merged 34 commits into from
Sep 5, 2024
Merged

fix: Fix duplicated "Microsoft." in resource type in output messages #262

merged 34 commits into from
Sep 5, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jul 8, 2024

Overview/Summary

Fixed Microsoft.microsoft in resource type in output messages.

image

Related Issues/Work Items

None

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Screenshot

image

@tksh164 tksh164 requested a review from a team as a code owner July 8, 2024 07:08
@ejhenry ejhenry added Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team Area: Tools 🧰 Related to the tools directory and/or content labels Jul 8, 2024
oZakari
oZakari previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari requested a review from a team July 9, 2024 00:29
@oZakari oZakari requested a review from kpoineal July 17, 2024 17:30
@tksh164 tksh164 changed the title Fix duplicated "Microsoft." in resource type in output messages fix: Fix duplicated "Microsoft." in resource type in output messages Jul 24, 2024
@tksh164
Copy link
Member Author

tksh164 commented Aug 1, 2024

@caseywatson @kpoineal @Claudio-Merola Would you be willing to review this PR? This PR has been over 3 weeks with no reviews. Thanks.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Aug 26, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Sep 5, 2024

@kpoineal @Claudio-Merola please review

@kpoineal
Copy link
Contributor

kpoineal commented Sep 5, 2024

@tksh164 Hey sorry about the long wait to review this. Is this still occurring? I haven't seen this behavior with the most recent updates.

@tksh164
Copy link
Member Author

tksh164 commented Sep 5, 2024

@kpoineal Yes, this still exist in the latest script. The released and in dev-tools both scripts.

image

@kpoineal
Copy link
Contributor

kpoineal commented Sep 5, 2024

Approved.

@kpoineal kpoineal merged commit 98a4091 into Azure:main Sep 5, 2024
3 of 4 checks passed
@tksh164 tksh164 deleted the fix-wara_collector-message branch September 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpoineal kpoineal kpoineal approved these changes

@oZakari oZakari oZakari approved these changes

Assignees

@caseywatson caseywatson

@kpoineal kpoineal

@Claudio-Merola Claudio-Merola

Labels
Area: Tools 🧰 Related to the tools directory and/or content Bug 🐞 Something isn't working Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tksh164 @ejhenry @kpoineal @oZakari @caseywatson @Claudio-Merola