fix recovoery requires vmss state file (#107)

Azure · Feb 1, 2024 · 6cb8997 · 6cb8997
1 parent f172ef8
commit 6cb8997
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/...adBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1 b/...adBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1
@@ -12,7 +12,7 @@
     RootModule = 'AzureBasicLoadBalancerUpgrade'
 
     # Version number of this module.
-    ModuleVersion = '2.4.4'
+    ModuleVersion = '2.4.5'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()
@@ -107,7 +107,7 @@
             # IconUri = ''
 
             # ReleaseNotes of this module
-            ReleaseNotes = 'Enhanced -multiLBConfig validation to prevent incorrect useage'
+            ReleaseNotes = 'Fix VMSS state file parameter always required in recovery'
 
             # Prerelease string of this module
             # Prerelease = ''

diff --git a/...cerUpgrade/modules/Start-AzBasicLoadBalancerUpgrade/Start-AzBasicLoadBalancerUpgrade.psm1 b/...cerUpgrade/modules/Start-AzBasicLoadBalancerUpgrade/Start-AzBasicLoadBalancerUpgrade.psm1
@@ -152,15 +152,13 @@ function Start-AzBasicLoadBalancerUpgrade {
         [Parameter(Mandatory = $True, ParameterSetName = 'ByName')][string] $BasicLoadBalancerName,
         [Parameter(Mandatory = $True, ValueFromPipeline, ParameterSetName = 'ByObject')][Microsoft.Azure.Commands.Network.Models.PSLoadBalancer] $BasicLoadBalancer,
         [Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVm')][string] 
-        [Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVmss')][string]
-        $FailedMigrationRetryFilePathLB,
-        [Parameter(Mandatory = $True, ParameterSetName = 'ByJsonVmss')][string] $FailedMigrationRetryFilePathVMSS,
+        [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string]$FailedMigrationRetryFilePathLB,
+        [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string] $FailedMigrationRetryFilePathVMSS,
         [Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][string]
         [Parameter(Mandatory = $false, ParameterSetName = 'ByName')][string]
         [Parameter(Mandatory = $false, ParameterSetName = 'ByObject')][string]
         [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVm')][string] 
-        [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string] 
-        $StandardLoadBalancerName,
+        [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][string] $StandardLoadBalancerName,
         [Parameter(Mandatory = $false)][string] $RecoveryBackupPath = $pwd,
         [Parameter(Mandatory = $false)][switch] $FollowLog,
         [Parameter(Mandatory = $false)][switch] $validateScenarioOnly,
@@ -169,8 +167,7 @@ function Start-AzBasicLoadBalancerUpgrade {
         [Parameter(Mandatory = $false, ParameterSetName = 'ByObject')][switch]
         [Parameter(Mandatory = $false, ParameterSetName = 'ByJsonVmss')][switch] 
         [Parameter(Mandatory = $false, ParameterSetName = 'MultiLB')][switch] 
-        [Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][switch]
-        $skipUpgradeNATPoolsToNATRules,
+        [Parameter(Mandatory = $false, ParameterSetName = 'ValidateCompletedMigration')][switch]$skipUpgradeNATPoolsToNATRules,
         [Parameter(Mandatory = $true, ParameterSetName = 'ValidateCompletedMigration')][switch] $validateCompletedMigration,
         [Parameter(Mandatory = $true, ParameterSetName = 'ValidateCompletedMigration')][string] $basicLoadBalancerStatePath,
         [Parameter(Mandatory = $false)][switch] $outputMigrationValiationObj,