Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(helper): add coverage on getTargetEnvironment method #5639

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

techworldhello
Copy link
Collaborator

@techworldhello techworldhello commented Jan 22, 2025

What type of PR is this?

/kind test

What this PR does / why we need it:

None of the cases in the getTargetEnvironment helper method were covered by tests.

Which issue(s) this PR fixes:

(no issue created)

Requirements:

Special notes for your reviewer:

Release note:

none

@techworldhello techworldhello force-pushed the wangjessi/increase-test-coverage branch from bc88d31 to c4ece9b Compare January 22, 2025 06:09
@techworldhello techworldhello changed the title Test: add coverage on getTargetEnvironment helper method test(helper): add coverage on getTargetEnvironment method Jan 22, 2025
@techworldhello
Copy link
Collaborator Author

@techworldhello please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@techworldhello techworldhello enabled auto-merge (squash) January 23, 2025 05:23
@techworldhello techworldhello merged commit c16abcc into master Jan 23, 2025
19 checks passed
@techworldhello techworldhello deleted the wangjessi/increase-test-coverage branch January 23, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants