refactor: manually generate self-signed kubelet serving cert when opting out of certificate rotation #5511
+4,947
−2,605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing out of certificate rotation
added 2 commits
January 7, 2025 10:23
cameronmeissner
requested review from
juan-lee,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
|
relevant abe2e scenarios are passing, failures are unrelated |
lilypan26
approved these changes
Jan 7, 2025
…sner/kscr-opt-out-certs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
in cases where customers want to manually opt-out of kubelet serving cert rotation via nodepool tag, this PR ensures that the self-signed certificate their kubelets end up getting look exactly the same as the self-signed certs they'd get if they hadn't been onboarded to kubelet serving certificate rotation in the first place - this is accomplished by calling the
generateSelfSignedKubeletServingCertificatefunction explicitly and passing in--tls-cert-file/--tls-private-key-fileto the kubelet, rather than letting kubelet generate its own self-signed cert at startup time.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: