feat: Add support for setting a different CNI config on cilium clusters #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshmprabhu
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
tamilmani1989
approved these changes
Jan 2, 2025
timmy-wright
reviewed
Jan 2, 2025
timmy-wright
reviewed
Jan 2, 2025
timmy-wright
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
We are currently adding support for Windows nodepools on nodesubnet clusters that use Cilium as the CNI plugin. In this setting, windows nodes are expected to use stateless Azure CNI, while Linux nodes use Cilium. In non-Cilium Nodesubnet clusters, the Windows nodes use stateful Azure CNI. Stateless Azure CNI requires a different conflist than stateful Azure CNI. In this PR, we pass information about whether the cluster is using Cilium or not, so that the conflist can be updated to suit stateful or stateless CNI.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: