Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cve-query step #5455

Open
wants to merge 4 commits into
base: ccoa/2024-2025
Choose a base branch
from
Open

Conversation

jason1028kr
Copy link
Collaborator

@jason1028kr jason1028kr commented Dec 19, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Pipeline changes for adding blocking criteria step

  • SKIP_CVE_QUERY, QUERY_POOL env variables to specify runs/pools.
  • trigger weekly release build from test build completion.
  • running kusto query on a vm built on generic vhd image (could do this on 1es pool, but the code will eventually sit next to scanning when TME daily build is implemented. so decided on an implementation that mirrors scanning step).

Not sure it's worth it to change current weekly release build behavior to depend on test build, for this block functionality. Might be best to make this wait until daily build feature is done.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@jason1028kr jason1028kr force-pushed the jasonjung/test-query-0 branch from dc31001 to eaf364d Compare December 25, 2024 21:31
@jason1028kr jason1028kr force-pushed the jasonjung/test-query-0 branch from 8d8fa9d to 177c242 Compare December 27, 2024 21:03
@jason1028kr jason1028kr marked this pull request as ready for review December 27, 2024 21:24
condition: ne(variables.SKIP_CVE_QUERY, 'true')
jobs:
- job: cveQuery
pool: $(QUERY_POOL_NAME)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is coming from a variable group can you explicitly declare the group at the top of the yaml to minimize confusion?

@cameronmeissner
Copy link
Collaborator

Not sure it's worth it to change current weekly release build behavior to depend on test build, for this block functionality. Might be best to make this wait until daily build feature is done. I'd also prefer to hold off on this for now until we've ironed out any potential kinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants