Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v4 migration - updates (DO NOT MERGE) #404

Closed
wants to merge 8 commits into from

Conversation

dfberry
Copy link
Contributor

@dfberry dfberry commented Nov 12, 2023

Fixes #396, #386, #350

Changes

  1. infra: secrets for cosmosdb, postgresdb, and appinsights are in keyvault
  2. scripts: key vault secrets read into env for db restore
  3. packages: api -> api-legacy (v3 programming model)
  4. packages: api-v4 -> api (v4 programming model)
  5. packages/api/src: @azure/identity -> v4.0.0
  6. packages/api/src/index.ts: function names: remove duplicate and rename for function-verb
  7. packages/api/src/config/index: use appInsights

Verify changes requires the following:

  1. do not deploy stripe package - this is unrelated to changes in this PR but does fail the deployment so comment out the stripe service in azure.yml before deploying
  2. SWA ssl error - still unclear what that is - but I worked it around it by changing the URL to http then continuing past the warning, then it redirects to the correct SWA + data returned from Fns - it looked it @manekinekko might be looking into this

https://green-field-052295603.4.azurestaticapps.net/home

image

@glaucia86 - fyi

@manekinekko @anfibiacreativa Ready for review.

@glaucia86
Copy link
Contributor

glaucia86 commented Nov 12, 2023

Thanks, @dfberry!

p.s.: just for your information, @dfberry and I made code review together this PR last Friday (11/10), once is related with the v3 to v4 migration PR

@manekinekko
Copy link
Collaborator

I've got a few issues when:

  1. after logged in successfully, I was redirected to /home with a blank screen
  2. when I clicked on a favorite button, I got a 500 error on the API call
  3. when I clicked on the reserve button I got the pop alerte
    image

@dfberry dfberry changed the title API v4 migration - updates API v4 migration - updates (DO NOT MERGE) Nov 17, 2023
@dfberry
Copy link
Contributor Author

dfberry commented Nov 17, 2023

Working with @jongio and @glaucia86 for infra corrections.

@diberry
Copy link
Collaborator

diberry commented Jan 2, 2024

Closing - the infra updates need to be separated from the API v4.

@diberry diberry closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] api-v4 package: double entry of @azure/functions
4 participants