Merge pull request #1480 from Availity/feature/feedback-form

feat: ON-10523 feedback text area optional in feedback form component
Availity · Oct 23, 2024 · 11fd4d7 · 11fd4d7
2 parents ae40619 + eed0e83
commit 11fd4d7
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/packages/feedback/src/FeedbackForm.js b/packages/feedback/src/FeedbackForm.js
@@ -30,6 +30,7 @@ const FeedbackForm = ({
   onClose,
   faceOptions,
   aboutOptions = [],
+  feedbackText = true,
   aboutLabel = 'This is about',
   onFeedbackSent,
   prompt,
@@ -129,7 +130,10 @@ const FeedbackForm = ({
           smileField: undefined,
         }}
         validationSchema={yup.object().shape({
-          feedback: yup.string().max(200, 'Feedback cannot exceed 200 characters.').required('This field is required.'),
+          feedback: yup
+            .string()
+            .max(200, 'Feedback cannot exceed 200 characters.')
+            .isRequired(feedbackText, 'This field is required.'),
           additionalFeedback: yup.string().max(200, 'Additional Feedback cannot exceed 200 characters.'),
           smileField: yup
             .object()
@@ -276,6 +280,8 @@ FeedbackForm.propTypes = {
       value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
     })
   ),
+  /** If false, then feedback text area is made optional */
+  feedbackText: PropTypes.bool,
   /** Label text for the dropdown created via the aboutOptions prop. Default: "This is about".
    *Previously aboutPlaceholder. All placeholders replaced with labels starting v6.0.0. */
   aboutLabel: PropTypes.node,

diff --git a/packages/feedback/tests/FeedbackForm.test.js b/packages/feedback/tests/FeedbackForm.test.js
@@ -89,6 +89,28 @@ describe('FeedbackForm', () => {
     );
   });
 
+  test('should submit without feedback text value when feedbackText set to false', async () => {
+    const onFeedbackSent = jest.fn();
+
+    const { getByText } = render(<FeedbackForm onFeedbackSent={onFeedbackSent} name="Payer Space" feedbackText={false}/>);
+
+    // Simulate the Click
+    fireEvent.click(getByText('Smiley face'));
+
+    fireEvent.click(getByText('Send Feedback'));
+
+    await waitFor(
+      () => {
+        expect(onFeedbackSent).toHaveBeenCalledWith(
+          expect.objectContaining({
+            active: 'smile',
+          })
+        );
+      },
+      { timeout: 2500 }
+    );
+  });
+
   test('should submit and disable button when clicked', async () => {
     // mock log messages api to return a promise that resolves after 3 seconds
     avLogMessagesApiV2.info = jest.fn(