Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to marker properties that can hold a column name #644

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Jan 3, 2024

Resolves #622.

marker = dict(colors="colors_col")

@FredLL-Avaiga FredLL-Avaiga added 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End Gui: Back-End labels Jan 3, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Jan 3, 2024
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great great one liner PR

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must be kidding me

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.42263483642794%

St.
Category Percentage Covered / Total
🟢 Statements
80.6% (+0.05% 🔼)
2289/2840
🟡 Branches
62.42% (-0.54% 🔻)
1412/2262
🟡 Functions
74.72% (-0.28% 🔻)
399/534
🟢 Lines
80.98% (+0.07% 🔼)
2125/2624
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
66.67% 17.65% 50% 66.67%
🟡
... / index.ts
73.33% 26.67% 50% 72.73%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from ebd4289

@FredLL-Avaiga FredLL-Avaiga merged commit 9f090c6 into develop Jan 3, 2024
64 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#622-marker-colors branch January 3, 2024 16:11
@FabienLelaquais FabienLelaquais changed the title Add colors to marker properties that can hold a column name (#622) Add colors to marker properties that can hold a column name Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gui: Back-End GUI: Front-End 📈 Improvement Improvement of a feature. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
3 participants