-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#359 - Use ruff #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewer:
Approved for gui only and with a few comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of very good changes. A few strange things.
279f49e
163f6fc
to
f3487d0
Compare
a7ee934
to
675e281
Compare
# Conflicts: # .github/workflows/partial-tests.yml # Pipfile # tests/core/_orchestrator/test_orchestrator.py # tests/core/test_core_cli.py
2231867
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 80.6% | 2289/2840 |
🟡 | Branches | 62.42% | 1412/2262 |
🟡 | Functions | 74.72% | 399/534 |
🟢 | Lines | 80.98% | 2125/2624 |
Test suite run success
334 tests passing in 36 suites.
Report generated by 🧪jest coverage report action from 8296734
#359
TODO:
# type: ignore
mypy
since Ruff is a linter and mypy is a type checkersetup.py
files