Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#359 - Use ruff #626

Merged
merged 17 commits into from
Jan 3, 2024
Merged

Feature/#359 - Use ruff #626

merged 17 commits into from
Jan 3, 2024

Conversation

trgiangdo
Copy link
Member

@trgiangdo trgiangdo commented Dec 21, 2023

#359

TODO:

  • Revisit # type: ignore
  • Merge with new linter workflows and use ruff instead of other tools
  • Re-enable mypy since Ruff is a linter and mypy is a type checker
  • Remove explicit ignore rules
  • Enable linter on setup.py files
  • Line length limit should also count comments

Copy link
Member Author

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer:

ruff.toml Outdated Show resolved Hide resolved
ruff.toml Show resolved Hide resolved
taipy/gui/_renderers/builder.py Show resolved Hide resolved
taipy/gui/_renderers/builder.py Show resolved Hide resolved
taipy/gui/_renderers/builder.py Show resolved Hide resolved
tests/gui/builder/control/test_chart.py Show resolved Hide resolved
tests/gui/utils/test_map_dict.py Show resolved Hide resolved
FredLL-Avaiga
FredLL-Avaiga previously approved these changes Dec 21, 2023
taipy/gui/gui_actions.py Show resolved Hide resolved
taipy/gui/gui_actions.py Show resolved Hide resolved
taipy/gui/server.py Show resolved Hide resolved
@FredLL-Avaiga
Copy link
Member

Approved for gui only and with a few comments

gmarabout
gmarabout previously approved these changes Dec 21, 2023
Copy link
Contributor

@gmarabout gmarabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏🏻

ruff.toml Show resolved Hide resolved
taipy/__init__.py Outdated Show resolved Hide resolved
taipy/config/_serializer/_json_serializer.py Show resolved Hide resolved
taipy/config/stubs/generate_pyi.py Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job!

ruff.toml Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
ruff.toml Show resolved Hide resolved
taipy/core/_repository/_decoder.py Show resolved Hide resolved
taipy/gui/gui_actions.py Show resolved Hide resolved
tests/gui/builder/control/test_chart.py Show resolved Hide resolved
jrobinAV
jrobinAV previously approved these changes Dec 21, 2023
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of very good changes. A few strange things.

ruff.toml Show resolved Hide resolved
ruff.toml Outdated Show resolved Hide resolved
ruff.toml Show resolved Hide resolved
ruff.toml Show resolved Hide resolved
taipy/config/stubs/generate_pyi.py Show resolved Hide resolved
tests/core/sequence/test_sequence.py Show resolved Hide resolved
tests/core/task/test_task.py Show resolved Hide resolved
tests/core/task/test_task.py Show resolved Hide resolved
tests/gui/builder/control/test_chart.py Show resolved Hide resolved
tests/gui/gui_specific/test_state.py Show resolved Hide resolved
jrobinAV
jrobinAV previously approved these changes Dec 22, 2023
jrobinAV
jrobinAV previously approved these changes Dec 26, 2023
# Conflicts:
#	.github/workflows/partial-tests.yml
#	Pipfile
#	tests/core/_orchestrator/test_orchestrator.py
#	tests/core/test_core_cli.py
@jrobinAV jrobinAV dismissed stale reviews from florian-vuillemot and themself via 2231867 January 3, 2024 16:48
jrobinAV
jrobinAV previously approved these changes Jan 3, 2024
doc/gui/extension/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.42263483642794%

St.
Category Percentage Covered / Total
🟢 Statements 80.6% 2289/2840
🟡 Branches 62.42% 1412/2262
🟡 Functions 74.72% 399/534
🟢 Lines 80.98% 2125/2624

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 8296734

@jrobinAV jrobinAV merged commit b3ec843 into develop Jan 3, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants