Multiple "Edit" links when viewing the site as an admin

[niranjan-uma-shankar]

Quick summary

This follows the comment made in p1725864908061989-slack-C029GN3KD.

(1) When viewing the site as an admin, there are five edit links. Should we remove some of these?

(2) The “Edit site” links on the page take to different destinations:

• the one in the masterbar links to:
  https://{SITE_SLUG}.wordpress.com/wp-admin/site-editor.php?postType=wp_template&postId=pub/marl//header-footer-only&canvas=edit, which opens a page with an inserted template.
• the one in the actionbar links to:
  https://{SITE_SLUG}.wordpress.com/wp-admin/site-editor.php?postType=wp_template&postId=pub/marl//header-footer-only
  which opens the template selector.

Both of them don’t seem to be apt destinations. It appears to me that we should be taking them to the root view - https://{SITE_SLUG}.wordpress.com/wp-admin/site-editor.php
which is what the Customizer links to.

(3) While we're at it, the site editor link in "My Home" can also be made to the point to the root view.

(4) Check #94358 (comment)

Steps to reproduce

1. Create a new site and go to site at https://{SITE_SLUG}.wordpress.com
2. Notice the multiple edit links.

Browser

No response

Other notes

No response

[jeherve]

Moving this to the Calypso repository, since this repo is about the bug reporting tool, Bugomattic.

[jeherve]

The one element that seems most likely to be removable is the one we add via the custom top toolbar:

wp-calypso/client/post-editor/editor-document-head/index.jsx

Line 11 in f2e6f88

function EditorDocumentHead( { translate, siteId, type, typeObject, newPost } ) {

The 2 others are part of WordPress itself, and make sense to appear in the admin bar imo. They also link to 2 different editors.

[davemart-in]

I agree with @jeherve.

[davemart-in]

Here's what I shared in Slack:

I'd say, remove the one in the action bar and update the one in the masterbar to point to the root view.

[richtabor]

I’d propose removing Edit Site from both the action bar and the master bar.

Generally, I think we’re pushing folks too often into the site editor directly without a clear intent (like customizing styles, or changing colors).

[niranjan-uma-shankar]

Is the appearance of the buttons theme specific? The screenshot in the issue description is of the Marl theme. On the "Fewer" theme, I see only the "Edit site" link:

[jeherve]

I’d propose removing Edit Site from both the action bar and the master bar.

Wouldn't that introduce a discrepancy between Core and WordPress.com, something that we've been trying to reduce in the past few months? If the "Edit Site" button is confusing in the admin bar, maybe it should be removed from Core directly?

[mmtr]

I'd say, remove the one in the action bar and update the one in the masterbar to point to the root view.

I think "one" here refers to the "Edit site" link, right? This might have some unexpected implications for the action bar, because it would be empty for example when visiting the homepage:

Current	Proposed

That action bar with just an ellipsis button looks quite wrong to me, so I'm moving this back to "Needs design" because I think we need to revisit how the action bar should look like under these circumstances.

---

Also, the initial report also indicated that the "Edit page" link (only visible when viewing a page) is duplicated across 3 sections:

• Top toolbar
• Launch banner (only on unlaunched sites)
• Action bar

For consistency with the "Edit site" link, I think we want to remove it from both the action bar and the launch banner, and leave only the one in the top toolbar, which is what comes from Core.

[ramonjd]

This might have some unexpected implications for the action bar, because it would be empty for example when visiting the homepage:

That's the result I'm seeing in D162881-code too.

Why not remove the floating admin bar entirely, or redesign it to house whatever useful links it contains? E.g., stats/subs

What is the real value of the floating admin bar? Are there stats to speak to its benefit?

[richtabor]

That action bar with just an ellipsis button looks quite wrong to me, so I'm moving this back to "Needs design" because I think we need to revisit how the action bar should look like under these circumstances.

That's better than an Edit Site link that makes it too easy to break the site: #95363

What is the real value of the floating admin bar? Are there stats to speak to its benefit?

I too would like to validate the action bar in full. Are folks using it, successfully? Who can we reach out to do this? #96202

Why not remove the floating admin bar entirely, or redesign it to house whatever useful links it contains? E.g., stats/subs

I don't want to redesign auxiliary interfaces that WordPress already supports (admin bar for example).