Ensure "Edit Site" option is consistent in both places (top toolbar and floating toolbar)

[annezazu]

Steps to reproduce

1. Look at the front end of a logged in site with a block theme
2. Notice there's "edit site" in the floating toolbar and "edit site" in the top toolbar.
3. Click each and notice they take you different places. Edit site in floating toolbar takes you to the Site Editor > Templates where as "Edit site" in the top toolbar will take you to the respective template you are choosing.

What I expected

Expect the buttons to act the same.

What happened instead

The buttons took me two different places.

Browser / OS version

MacOS, Chrome

Screenshot / Video

edit.site.mov

[ramonjd]

I noticed there's an item from @richtabor to remove the "Edit site" link from the floating action toolbar completely.

It might save adding the logic in Calypso to take you to the respective template you are choosing.

Then again, while testing it, I noticed that canvas=edit is missing from the link.

YOUR_WORDPRESS_COM_SITE/wp-admin/site-editor.php?postType=wp_template&postId=pub%2Fassembler%2F%2Fhome

vs

YOUR_WORDPRESS_COM_SITE/wp-admin/site-editor.php?postType=wp_template&postId=pub%2Fassembler%2F%2Fhome&canvas=edit

The latter will open the editor.

This is a DotCom backend change regardless of which happens. 👍🏻 See

p1725838043966329-slack-C07H21B2W59?thread_ts=1725637696.261559&cid=C07H21B2W59

[ramonjd]

This is a DotCom backend change regardless of which happens.

If we remove the "Edit site" link, I'd assume the "Customize" link should stay for classic themes?

[ramonjd]

I've appended "canvas=edit" to these links so that the editor opens.

Kapture.2024-10-02.at.15.59.29.mp4

D162881-code

[ramonjd]

D162881-code now removes the Edit Site from the toolbar completely

Related issue:

• Update the “Edit site” admin bar control to open the Site Editor at the top-level, consistently WordPress/gutenberg#63785

[niranjan-uma-shankar]

Related issue:

• Multiple "Edit" links when viewing the site as an admin #94358

[ramonjd]

I think this PR is waiting on a redesign. See @mmtr's comments:

That action bar with just an ellipsis button looks quite wrong to me, so I'm moving this back to "Needs design" because I think we need to revisit how the action bar should look like under these circumstances.

D162881-code removes the "Edit Site" link and the result is a lonely ellipsis button. 😄

[richtabor]

I noticed there's an item from @richtabor to remove the "Edit site" link from the floating action toolbar completely.

Yes, let's just remove "Edit site" from the action bar. It's not the same as "Customize" — which is a much more contained environment where it's harder to break your website: #95363

There's an argument for removing "Customize" as well, since it's repeated in the admin bar. Shall I propose that in a follow-up?

[simison]

@richtabor are we removing "edit" (post) link as well from Action bar? It's in the masterbar, too:

[ramonjd]

Progress on this has stalled. Just x-linking pfYzsZ-On-p2#comment-966

[simison]

@ramonjd question of removing entirely shouldn't block you from improving/removing edit-links meanwhile, especially if it seems like Action bar will remain there at least for the time being. :-)

[ramonjd]

question of removing entirely shouldn't block you from improving/removing edit-links meanwhile

Thanks for the clarification @simison 👍🏻

[richtabor]

Yes, can we remove "Edit Site" at the very least?

[ramonjd]

For folks coming back to this, D162881-code revision ID 534689 removed the "Edit Site" option.

[simison]

I noticed we also have "Customize" visible in the masterbar alongside "Edit site" :-(

Filed an issue:

• Jetpack Search: customizer visible for block themes #97735

[ramonjd]

My vote is to remove the floating toolbar completely.

If that's too radical for folks, then let's get rid of all Edit links in the toolbar.

Also, the "Get theme:" for logged in users looking at their own site. It's redundant: there's no need to get the theme that's already installed.

The window prompt to copy the short link is also from the jurassic period.

Maybe something like this?

Kapture.2024-12-27.at.18.08.16.mp4

[ramonjd]

Yes, can we remove "Edit Site" at the very least?

I ported the phab patch that removed the "Edit Site" link over to 169373-ghe-Automattic/wpcom

[davemart-in]

My vote is to remove the floating toolbar completely.

I'd ask that we please not do this. It is still valuable, especially for blogger engagement.

Happy to:

A) Cull links that no longer make sense.
B) Make the action bar optional - so anyone could turn it off if they want (but still defaulting it to be on)
C) Redesign the action bar to align more with Gutenberg. Here were a few designs I shared:

[ramonjd]

I'd ask that we please not do this. It is still valuable, especially for blogger engagement.

👍🏻

Redesign the action bar to align more with Gutenberg. Here were a few designs I shared:

Looks great, thanks for sharing.

I'll leave 169373-ghe-Automattic/wpcom as is (just removing Edit Site) for now so that's addressed at least for this issue.

The redesign is a chunkier bit of work we can swing back to.

[ramonjd]

169373-ghe-Automattic/wpcom has been committed.

Can we close this?

[ramonjd]

Closing for now as "Edit Site" no longer exists in the floating toolbar.

See also: Automattic/jetpack#41137 which updates the admin bar "Edit Site" link to point to the top level site editor always.