Blockbase: allow individual style variation to be removed. #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview changesI've detected changes to the following themes in this PR: Blockbase. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
pkevan
commented
Jan 31, 2025
| $handler_method = isset( $handler['callback'][1] ) ? $handler['callback'][1] : null; | ||
| $remove_variations = wp_get_global_settings( array( 'custom', 'excludedParentStyleVariations' ) ); | ||
|
|
||
| if ( is_a( $handler_class, 'WP_REST_Global_Styles_Controller_Gutenberg' ) && 'get_theme_items' === $handler_method && ! empty( $remove_variations ) ) { |
There was a problem hiding this comment.
this needs to change to allow for when the Gutenberg plugin is active, and not, as per #8638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #8671, the option to opt-out of parent styles individually via
excludedParentStyleVariationscustom option currently doesn't work - this allow the functionality to be corrected.