Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexionic: add theme #8637

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Lexionic: add theme #8637

merged 4 commits into from
Jan 31, 2025

Conversation

henriqueiamarino
Copy link
Collaborator

Lexiconic is a sleek, versatile theme that empowers book authors, publishers, and storytellers. Its particular layout makes it easy to create stunning landing pages and offers a seamless way to showcase a piece of writing.

Demo site | Site content export

screenshot

@henriqueiamarino henriqueiamarino self-assigned this Jan 28, 2025
@henriqueiamarino henriqueiamarino added the Waiting Review Add this label if this is the first PR for a new theme label Jan 28, 2025
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Lexionic.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi
Copy link
Contributor

iamtakashi commented Jan 29, 2025

@henriqueiamarino Here are my notes. The number of things I need to mention is getting less and less. Great job!

  • I've noticed that the custom spacing sizes defined in the theme.json aren't working. If the JSON file is version 3, the defaultSpacingSizes must be false to override the default spacing size. Example. I reviewed the theme as if the custom spacing sizes are actually working, but please fix it in the next update.
  • Most of the custom duotones aren't used in the theme, do we need them?
  • I like the unique-looking CTA in the footer, but it's not looking great on small screens. Can we take a different approach to make it work on both large and small screen sizes?
    CleanShot 2025-01-29 at 14 42 11@2x
  • It's not a problem, but why do the images on the blog home template use the cover blocks but not the image blocks?
  • It's probably better to use a heading for the text "Homer". It's awkward in the variations that use a font with a strong character for headings.
    CleanShot 2025-01-29 at 15 17 44@2x
  • A main tag is missing in all templates.
  • Remove the following unused patterns. patterns/single.php, patterns/page.php,
  • All the style variations have custom duotones. Do we actually need them? If we do, it's probably better if they were registered in the default json.
  • Change the Requires PHP: to 7.2 in both readme.txt and style.css
  • Let's add credits to the rest of two images bundled with the theme.
  • Thanks for paying attention to the theme tags! You can also add block-styles and full-site-editing.

@henriqueiamarino
Copy link
Collaborator Author

Thanks @iamtakashi. Although the check has failed, I believe I fixed all the issues.
Here's the checklist:

  • I tried to fix the custom spacing sizes issue by adding the line defaultSpacingSizes: false. I am not sure if this is enough. Please let me know;
  • I removed all the duotones. They belong to an initial idea that is now gone. I did it on the style variations, as well;
  • The footer CTA was repaired to look better. Thanks for checking it;
  • I am using a cover instead of an image to ensure the aspect ratio is set to 3:2. We can't control AR on images; we can only upload cut ones. But that would be a hack, and users wouldn't follow it. Do you think this is a problem?
  • Made the author's text into a Heading;
  • Added a main tag to all the Content wrappers;
  • Removed the unused patterns: single and page.php;
  • Changed the Required PHP to 7.2;
  • Added the credit to the image that was missing;
  • Added the extra tags you mentioned.

@iamtakashi
Copy link
Contributor

@henriqueiamarino, thanks for the update! Most of the issues were addressed correctly 👍

  • Thanks for removing the custom duotones, but it's still used in here and here.
  • The credit for the shadow image is missing.
  • The height of the button is now different between the block variations. You have fixed the same issue here. However, this time, the border thickness is 2px.
    CleanShot 2025-01-30 at 12 18 31@2x

@iamtakashi iamtakashi added Under Review It's being reviewed atm. and removed Waiting Review Add this label if this is the first PR for a new theme labels Jan 30, 2025
@iamtakashi iamtakashi merged commit cbbd539 into trunk Jan 31, 2025
1 of 2 checks passed
@iamtakashi iamtakashi deleted the add/lexionic branch January 31, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under Review It's being reviewed atm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants