Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar: Fix margin top-bottom on frontend #8605

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

cbravobernal
Copy link
Contributor

Changes proposed in this Pull Request:

Related issue(s):

Fixes this issue only in the Lodestar theme.

#6611

How to test it

Before the PR:

  • Use Lodestar theme.
  • Create or edit a page, add a couple of images on the editor.
  • Check that there is a margin in the editor.
  • Preview or publish the page, check that there are no margins.

After the PR:

  • Preview or publish the page, check that there are margins.
Screenshot 2025-01-21 at 13 52 13

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Lodestar.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as same as: #8594

@cbravobernal cbravobernal merged commit 636f48f into trunk Jan 23, 2025
2 of 3 checks passed
@cbravobernal cbravobernal deleted the fix/lodestar-block-image-margin branch January 23, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Lodestar [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants