Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penscratch 2: Fix margin top-bottom on frontend #8601

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

cbravobernal
Copy link
Contributor

Changes proposed in this Pull Request:

Related issue(s):

Fixes this issue only in the Penscratch 2 theme.

#6611

How to test it

Before the PR:

  • Use Penscratch 2 theme.
  • Create or edit a page, add a couple of images on the editor.
  • Check that there is a margin in the editor.
  • Preview or publish the page, check that there are no margins.

Screenshot 2025-01-20 at 17 43 02

After the PR:

  • Preview or publish the page, check that there are margins.

Screenshot 2025-01-20 at 17 42 44

@cbravobernal cbravobernal added the [Type] Bug Something isn't working label Jan 20, 2025
@cbravobernal cbravobernal self-assigned this Jan 20, 2025
Copy link
Contributor

Theme-Check results

penscratch-2: There are required changes on the theme ❌.

❎ REQUIRED

  • Could not find wp_body_open action or function call at the very top of the body just after the opening body tag. See: wp_body_open
  • HEADER_TEXTCOLOR was found in the file inc/custom-header.php. Use add_theme_support( 'custom-header' ) instead. Line 33: // get_header_textcolor() options: HEADER_TEXTCOLOR is default, hide text (returns 'blank') or any hex valueLine 34: if ( HEADER_TEXTCOLOR == $header_text_color ) {
  • Tested up to: is missing from your style.css header. Also, this should be numbers only, so 5.0 and not WP 5.0
  • Requires PHP: is missing from your style.css header.
💡 RECOMMENDED (5)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • .sticky css class is recommended in your theme css.
  • No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
⚠️ WARNING (7)
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Links'. Line 24: __( 'Links' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Blue & Red'. Line 45: ), __( 'Blue & Red' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Dark Blue'. Line 50: ), __( 'Dark Blue' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Dark Green'. Line 55: ), __( 'Dark Green' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Purple'. Line 60: ), __( 'Purple' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Teal'. Line 65: ), __( 'Teal') );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Red'. Line 70: ), __( 'Red' ) );

Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as same as: #8594

@cbravobernal cbravobernal merged commit 3d7a545 into trunk Jan 23, 2025
1 of 2 checks passed
@cbravobernal cbravobernal deleted the fix/penscratch-2-block-image-margin branch January 23, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Penscratch 2 [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants