Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dismiss policy for Toast view #2716

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2703

To be able to decide whether or not the Toast menu should auto dismiss, I introduced a policy enum to handle both cases:
• never
• interval

If the policy is set to never, the timer is never associated.
By default the policy is the interval keeping the same value as before.

To test

  • Run the app
  • Make sure the Toast continue working as before

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the [Type] Enhancement Improve an existing feature. label Jan 30, 2025
@danielebogo danielebogo added this to the 7.82 milestone Jan 30, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 30, 2025 19:06
@danielebogo danielebogo linked an issue Jan 30, 2025 that may be closed by this pull request
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor!

:shipit:

@danielebogo danielebogo merged commit 1310580 into trunk Jan 30, 2025
6 of 9 checks passed
@danielebogo danielebogo deleted the danieleb/update-toast branch January 30, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants