Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Podcast Feed Reload] Add Reload button #2709

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

danielebogo
Copy link
Contributor

πŸ“˜ Part of: #2703

Fixes #2704

This PR adds:
β€’ The new Feature Flag
β€’ The view model to handle the API call
β€’ The button into the Podcast view sheet
β€’ Simulates the API call

JHYUE4952.MOV

To test

  • Enable the podcastFeedUpdate FF
  • Open a podcast detail
  • Tap the β€’β€’β€’ button
  • Confirm you see the Refresh episode list as first button
  • Tap it
  • You should see the Toast being displayed and after few seconds a second toast saying there's no new episodes

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.82 milestone Jan 28, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 28, 2025 18:28
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly.

:shipit:

Just a small note to a follow up PR to dismiss the toasts when moving out of the screen.

@danielebogo
Copy link
Contributor Author

@SergioEstevao here #2712

@danielebogo danielebogo merged commit 2a3cd1f into trunk Jan 29, 2025
6 of 9 checks passed
@danielebogo danielebogo deleted the danieleb/PFR-2703/2704-reload-button branch January 29, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feed Reload button to Podcast Detail view
2 participants