Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics audit: Add missing sleep timer settings #2698

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 24, 2025

📘 Part of: #2628

Fixes #

1 2
Simulator Screenshot - iPhone 16 Pro Max - 2025-01-24 at 16 29 00 Simulator Screenshot - iPhone 16 Pro Max - 2025-01-24 at 16 31 47

To test

  • Start the app
  • Ensure that you have tracksLogging FF enabled
  • Start playing an episode
  • Open the full screen player
  • Tap on the Sleep Timer option
  • Check that you see a new settings icon on the top right of the timer modal
  • Tap on it
  • Check that you navigate to Settings->General and have the Sleep Timer section in view
  • Check that you see the event player_sleep_timer_settings_tapped on the console

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added Analytics Analytics related issues Sleep Timer labels Jan 24, 2025
@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 24, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 24, 2025 16:33
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 24, 2025 16:33
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 24, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see 🔵 Tracked: player_sleep_timer_settings_tapped and I get redirected to the settings

@SergioEstevao SergioEstevao merged commit db1e1ce into release/7.81 Jan 24, 2025
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the analytics-audit/add_missing_sleep_timer_settings branch January 24, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues Sleep Timer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants