Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics audit: update free up space event #2695

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

Add the missing source parameter when sending freeUpSpaceMaybeLaterTapped and set the check to percentage back to 10% of free space instead of 100%.

To test

In order to test it easier change the check for percentage on ManageDownloadsCoordinator.shouldShowBanner to 0.1

  1. Start the app fresh
  2. Do some downloads of episodes
  3. Go to Profile tab
  4. Tap on Downloads
  5. Tap on the X button
  6. Check that the freeUpSpaceMaybeLaterTapped is sent and source parameter is set to downloads

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 24, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 24, 2025 12:42
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 24, 2025 12:42
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 24, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! :shipit:

@SergioEstevao SergioEstevao merged commit 7fa1112 into release/7.81 Jan 24, 2025
6 of 10 checks passed
@SergioEstevao SergioEstevao deleted the analytics-audit/update_free_up_space branch January 24, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants