Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics Audit] Add the Discover List share button tapped event #2690

Merged

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2628

Adds the share button and the track event discover_list_share_tapped to the Discover lists

To test

  • Make sure you have the tracks log enabled
  • Go to discover
  • Expand a list by tapping Show All
  • Tap on the top right share icon
  • confirm you see 🔵 Tracked: discover_list_share_tapped tracked
  • Confirm you can copy or share the url
  • Open another list like BCG
  • Tap on the top right share icon
  • confirm you see 🔵 Tracked: discover_list_share_tapped tracked
  • Confirm you can copy or share the url

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the Analytics Analytics related issues label Jan 23, 2025
@danielebogo danielebogo added this to the 7.81 ❄️ milestone Jan 23, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 23, 2025 17:43
@danielebogo danielebogo linked an issue Jan 23, 2025 that may be closed by this pull request
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event being sent correctly.
:shipit:

@danielebogo danielebogo merged commit 8dc393c into release/7.81 Jan 24, 2025
6 of 9 checks passed
@danielebogo danielebogo deleted the danieleb/Analytics-Audit/discover-screen-share-list branch January 24, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Track Audit
3 participants