Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics Audit] OPML import finished property update #2686

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2628

Fixes #2677

Update the property for the opml_import_finished event.

To test

  • Make sure to have the tracks log enabled
  • Import an OPML file
  • Confirm it tracks 🔵 Tracked: opml_import_finished ["number_parsed": YOUR_NUMBER]

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the Analytics Analytics related issues label Jan 22, 2025
@danielebogo danielebogo added this to the 7.81 ❄️ milestone Jan 22, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 22, 2025 16:36
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 22, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment about the return being made on smaller OPML imports.

@@ -78,7 +78,7 @@ class OpmlImporter: Operation, XMLParserDelegate {
NotificationCenter.postOnMainThread(notification: Constants.Notifications.opmlImportCompleted)
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove this return or else if we are doing a smaller import the event bellow will not be tracked.

@danielebogo
Copy link
Contributor Author

@SergioEstevao I removed the return also for the failure. Have look and test to confirm

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!
:shipit:

@danielebogo danielebogo merged commit 1137eac into release/7.81 Jan 24, 2025
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/Analytics-Audit/2677-opml-import branch January 24, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants