Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics Audit] Add missing share events #2683

Merged

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2628

Fixes #2678

This PR adds the missing events for the Sharing action:

- share_screen_navigation_button_tapped
- share_screen_edit_button_tapped
- share_screen_close_button_tapped

To test

  • Run the app with the track log on
  • Play an episode and tap Share -> Clip
  • Tap on Next: confirm it tracks 🔵 Tracked: share_screen_navigation_button_tapped
  • Tap on Edit: confirm it tracks 🔵 Tracked: share_screen_edit_button_tapped
  • Tap on the close button (top right): confirm it tracks 🔵 Tracked: share_screen_close_button_tapped

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the Analytics Analytics related issues label Jan 22, 2025
@danielebogo danielebogo added this to the 7.81 ❄️ milestone Jan 22, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 22, 2025 13:12
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the new events are being tracked.
:shipit:

@danielebogo danielebogo merged commit 9a44b32 into release/7.81 Jan 24, 2025
6 of 9 checks passed
@danielebogo danielebogo deleted the danieleb/Analytics-Audit/2678-share-events branch January 24, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants