Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics Audit] Podcast view #2681

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

danielebogo
Copy link
Contributor

@danielebogo danielebogo commented Jan 22, 2025

📘 Part of: #2628

This PR adds:
• the missing podcast_screen_podcast_description_tapped event
• the missing podcast_uuid & is_private params to podcast_screen_share_tapped

To test

• Run the app with the trackers log on
• Go to a podcast screen
• tap on the share icon
• confirm podcast_screen_share_tapped is tracked with podcast_uuid & is_private params
• expand and collapse the podcast description
• confirm podcast_screen_podcast_description_tapped is tracked
• Upload a file and upload to the cloud
• In AnalyticsEpisodeHelper add a break point at line 200 and force the status to be uploadFailed
• confirm you see episode_upload_failed tracked with the episode_uuid

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the Analytics Analytics related issues label Jan 22, 2025
@danielebogo danielebogo added this to the 7.81 ❄️ milestone Jan 22, 2025
@danielebogo danielebogo requested a review from a team as a code owner January 22, 2025 11:30
@danielebogo danielebogo linked an issue Jan 22, 2025 that may be closed by this pull request
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 22, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both events are now being sent and with the correct parameters.

@danielebogo danielebogo merged commit aed130f into release/7.81 Jan 24, 2025
4 of 6 checks passed
@danielebogo danielebogo deleted the danieleb/Analytics-Audit/podcast-screen branch January 24, 2025 10:34
@danielebogo
Copy link
Contributor Author

Ref. #2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Track Audit
3 participants