Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics audit: Update general settings events #2675

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 21, 2025

📘 Part of: #2628

Fixes #2674

Adds the following missing events on general settings:

  • settingsGeneralEpisodeGroupingApplyToExisting
  • settingsGeneralEpisodeGroupingDoNotApplyToExisting
  • settingsGeneralArchivedEpisodesApplyToExisting
  • settingsGeneralArchivedEpisodesDoNotApplyToExisting

To test

  • Start the app
  • Ensure you have tracksLogging FF enabled
  • Tap on Profile tab
  • Tap on Settings ( cog icon )
  • Tap on General
  • Tap on Podcast Episode Grouping
  • Select one of the options
  • Tap on Apply to existing, check if the event settingsGeneralEpisodeGroupingApplyToExisting is sent
  • Tap again on Podcast Episode Grouping
  • Select one of the options
  • Tap on No Thanks, check if the event settingsGeneralEpisodeGroupingDoNotApplyToExisting is sent
  • Tap on Archived Episodes
  • Select one of the options
  • Tap on Apply to existing, check if the event settingsGeneralArchivedEpisodesApplyToExisting is sent
  • Tap again on Podcast Episode Grouping
  • Select one of the options
  • Tap on No Thanks, check if the event settingsGeneralArchivedEpisodesDoNotApplyToExisting is sent

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Analytics Analytics related issues label Jan 21, 2025
@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 21, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 21, 2025 23:08
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 21, 2025 23:08
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 21, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

🔵 Tracked: settings_general_episode_grouping_apply_to_existing ["theme_use_system_settings": true, "theme_selected": "default_dark", "theme_light_preference": "default_light", "theme_dark_preference": "default_dark"]
🔵 Tracked: settings_general_episode_grouping_do_not_apply_to_existing ["theme_light_preference": "default_light", "theme_use_system_settings": true, "theme_selected": "default_dark", "theme_dark_preference": "default_dark"]
🔵 Tracked: settings_general_archived_episodes_apply_to_existing ["theme_light_preference": "default_light", "theme_dark_preference": "default_dark", "theme_use_system_settings": true, "theme_selected": "default_dark"]
🔵 Tracked: settings_general_archived_episodes_do_not_apply_to_existing ["theme_light_preference": "default_light", "theme_dark_preference": "default_dark", "theme_use_system_settings": true, "theme_selected": "default_dark"]

@danielebogo danielebogo linked an issue Jan 22, 2025 that may be closed by this pull request
@SergioEstevao SergioEstevao merged commit 7c8efd9 into release/7.81 Jan 22, 2025
7 of 10 checks passed
@SergioEstevao SergioEstevao deleted the analytics-audit/2674_update_general_settings_events branch January 22, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Track Audit
3 participants