Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics audit: Implement select podcast events #2672

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 21, 2025

| 📘 Part of: #2628 |
|:---:|

Fixes #2645

Adds tracking event to track action on Podcast choose Picker:

  • settingsSelectPodcastsShown
  • settingsSelectPodcastsDismissed
  • settingsSelectPodcastsSelectAllTapped
  • settingsSelectPodcastsSelectNoneTapped
  • settingsSelectPodcastsPodcastToggled
  • settingsSelectPodcastsSelectAllPodcastsToggled

To test

  • Start the app
  • Ensure you have tracksLogging FF enabled
  • Go to Filters tab, and create a new filter
  • Tap on All Your Podcasts pill
  • Check if the event settingsSelectPodcastsShown is send and has the source property set to filters
  • Tap on the All Podcasts switch and check if settingsSelectPodcastsSelectAllPodcastsToggled is send and have the enable property correctly set and source property set to filters
  • Select a single podcast, check if settingsSelectPodcastsPodcastToggled is sent with the properties uuid, enabled and source correctly set
  • Deselect the single podcast, check if settingsSelectPodcastsPodcastToggled is sent with the properties uuid, enabled and source correctly set
  • Tap on Select All on the top right, check if settingsSelectPodcastsSelectAllTapped is sent with the property source correctly set
  • Tap on Deselect All on the top right, , check if settingsSelectPodcastsSelectNoneTapped is sent with the property source correctly set
  • Tap on X, check if settingsSelectPodcastsDismissed is sent

Check the same events are sent with the correct source when selecting podcasts on Auto-Downloads, Notifications and Auto-Add settings.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Analytics Analytics related issues label Jan 21, 2025
@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 21, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 21, 2025 15:39
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team January 21, 2025 15:39
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 21, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao requested review from danielebogo and removed request for bjtitus January 21, 2025 16:03
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao few things I noticed:

  • When tapping the pill to present the podcasts selection I see both shown and dismissed event tracked
🔵 Tracked: settings_select_podcasts_shown ["theme_dark_preference": "default_dark", "theme_use_system_settings": true, "theme_light_preference": "default_light", "source": "filters", "theme_selected": "default_dark"]
🔵 Tracked: settings_select_podcasts_dismissed ["theme_use_system_settings": true, "source": "filters", "theme_dark_preference": "default_dark", "theme_selected": "default_dark", "theme_light_preference": "default_light"]
  • When tapping the top right button to select/deselect all I don't see the value tracked. Only the source:
🔵 Tracked: settings_select_podcasts_select_all_tapped ["theme_light_preference": "default_light", "theme_use_system_settings": true, "source": "filters", "theme_selected": "default_dark", "theme_dark_preference": "default_dark"]
🔵 Tracked: settings_select_podcasts_select_none_tapped ["theme_light_preference": "default_light", "theme_use_system_settings": true, "theme_dark_preference": "default_dark", "source": "filters", "theme_selected": "default_dark"]

@SergioEstevao
Copy link
Contributor Author

settings_select_podcasts_select_all_tapped , settings_select_podcasts_select_none_tapped don't have any extra values just the source parameter

@danielebogo
Copy link
Contributor

• Tap on Select All on the top right, check if settingsSelectPodcastsSelectAllTapped is sent with the properties enabled and source correctly set
• Tap on Deselect All on the top right, , check if settingsSelectPodcastsSelectNoneTapped is sent with the properties enabled and source correctly set

@SergioEstevao so this is not correct? Both track only the source?

@SergioEstevao
Copy link
Contributor Author

@SergioEstevao so this is not correct? Both track only the source?

Correct, I did a mistake in the description when copying the lines across.

I also now updated the dismiss event to be sent at the correct time.

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. I can see the shown and dismissed tracked correctly

@danielebogo danielebogo linked an issue Jan 22, 2025 that may be closed by this pull request
@danielebogo danielebogo merged commit 0b4b5ba into release/7.81 Jan 22, 2025
4 of 6 checks passed
@danielebogo danielebogo deleted the analytics-audit/2645_implement_select_podcast_events branch January 22, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Track Audit
3 participants