-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics audit: Implement select podcast events #2672
Analytics audit: Implement select podcast events #2672
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergioEstevao few things I noticed:
- When tapping the pill to present the podcasts selection I see both shown and dismissed event tracked
🔵 Tracked: settings_select_podcasts_shown ["theme_dark_preference": "default_dark", "theme_use_system_settings": true, "theme_light_preference": "default_light", "source": "filters", "theme_selected": "default_dark"]
🔵 Tracked: settings_select_podcasts_dismissed ["theme_use_system_settings": true, "source": "filters", "theme_dark_preference": "default_dark", "theme_selected": "default_dark", "theme_light_preference": "default_light"]
- When tapping the top right button to select/deselect all I don't see the value tracked. Only the source:
🔵 Tracked: settings_select_podcasts_select_all_tapped ["theme_light_preference": "default_light", "theme_use_system_settings": true, "source": "filters", "theme_selected": "default_dark", "theme_dark_preference": "default_dark"]
🔵 Tracked: settings_select_podcasts_select_none_tapped ["theme_light_preference": "default_light", "theme_use_system_settings": true, "theme_dark_preference": "default_dark", "source": "filters", "theme_selected": "default_dark"]
|
@SergioEstevao so this is not correct? Both track only the source? |
Correct, I did a mistake in the description when copying the lines across. I also now updated the dismiss event to be sent at the correct time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now. I can see the shown and dismissed tracked correctly
| 📘 Part of: #2628 |
|:---:|
Fixes #2645
Adds tracking event to track action on Podcast choose Picker:
To test
settingsSelectPodcastsShown
is send and has thesource
property set tofilters
settingsSelectPodcastsSelectAllPodcastsToggled
is send and have theenable
property correctly set andsource
property set tofilters
settingsSelectPodcastsPodcastToggled
is sent with the propertiesuuid
,enabled
andsource
correctly setsettingsSelectPodcastsPodcastToggled
is sent with the propertiesuuid
,enabled
andsource
correctly setsettingsSelectPodcastsSelectAllTapped
is sent with the propertysource
correctly setsettingsSelectPodcastsSelectNoneTapped
is sent with the propertysource
correctly setsettingsSelectPodcastsDismissed
is sentCheck the same events are sent with the correct source when selecting podcasts on Auto-Downloads, Notifications and Auto-Add settings.
Checklist
CHANGELOG.md
if necessary.