Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics audit: update transcript show event #2671

Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 21, 2025

📘 Part of: #2628

Update event for transcript search show to match the name in Android

To test

  • Start the app
  • Ensure you have transcripts logging enabled
  • Open a podcast episode with a transcript. Ex: Cautionary Tales podcasts normally have transcript
  • Start playing it
  • Open the fullscreen player
  • Tap on the transcript button
  • Tap on Search, and check if the event transcript_search_shown

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Analytics Analytics related issues label Jan 21, 2025
@SergioEstevao SergioEstevao added this to the 7.81 ❄️ milestone Jan 21, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 21, 2025 14:11
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 21, 2025 14:11
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 21, 2025

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

🔵 Tracked: transcript_search_shown ["theme_use_system_settings": true, "theme_light_preference": "default_light", "episode_uuid": "af96b003-2773-4b95-b89f-c423e394e02d", "theme_selected": "default_dark", "podcast_uuid": "ba993300-d71c-0137-1e26-0acc26574db2", "theme_dark_preference": "default_dark"]

@SergioEstevao SergioEstevao merged commit 3f38ae0 into release/7.81 Jan 21, 2025
9 of 11 checks passed
@SergioEstevao SergioEstevao deleted the analytics-audit/update_transcript_events branch January 21, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants