Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track audit: Add missing filter events #2658

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 17, 2025

| 📘 Part of: #2628 |
|:---:|

Fixes #2644

Adds tracking for the following events:

  • filterCreateButtonTapped
  • filterAutoDownloadUpdated
  • filterAutoDownloadLimitUpdated

To test

  1. Start the app
  2. Ensure that you have the tracksLogging FF enabled
  3. Open the filters tab
  4. Scroll to the end of the list of filters
  5. Tap on the New Filter button
  6. Check if filterCreateButtonTapped is show in the console
  7. Customize the new filter with all different options and make sure to enable a duration filter
  8. Create the new filter
  9. Confirm in the console you see a filterCreated event with the following properties tracked "duration_shorter_than" , "not_downloaded", "duration_longer_than"
  10. Tap on the ... button on the new filter
  11. Select filter options
  12. Enable Auto-Download
  13. Chose a option to limit the number of downloads
  14. Check in the console if you see filter_auto_download_updated ["enabled": true, "source": "filters"] and
    filter_auto_download_limit_updated events

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Analytics Analytics related issues label Jan 17, 2025
@SergioEstevao SergioEstevao added this to the 7.81 milestone Jan 17, 2025
@SergioEstevao SergioEstevao marked this pull request as ready for review January 17, 2025 19:07
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 17, 2025 19:07
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team January 17, 2025 19:07
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergioEstevao
all good:

🔵 Tracked: filter_create_button_tapped
🔵 Tracked: filter_created ["episode_status_unplayed": true, "downloaded": true, "duration": true, "duration_shorter_than": 40, "episode_status_played": true, "starred": false, "episode_status_in_progress": true, "not_downloaded": true, "duration_longer_than": 20, "icon_name": "filter_list", "color": "#F43E37", "media_type": "all", "all_podcasts": true, "release_date": "24_hours"]
🔵 Tracked: filter_auto_download_updated ["enabled": true, "source": "filters"]
🔵 Tracked: filter_auto_download_limit_updated ["limit": 5]

@SergioEstevao SergioEstevao merged commit 2d91ec3 into trunk Jan 20, 2025
6 of 8 checks passed
@SergioEstevao SergioEstevao deleted the track_audit/2644_add_missing_filter_events branch January 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing filter track events
2 participants