Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track audit - Add missing user files events #2646

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 16, 2025

| 📘 Part of: #2628 |
|:---:|

Fixes #2640

This PR adds the following events:

  • userFileEditShown
  • userFileEditDismissed
  • userFileEditSave
  • userFileDeleteShown
  • userFileDeleteDismissed

It also fixes a duplicated call to the event uploadedFilesHelpButtonTapped when tapping Add Files when the list was empty

To test

  1. Start the app with a user with a subscription
  2. Ensure that you have tracksLogging FF enable
  3. Go to Profile Tab
  4. Scroll down
  5. Tap on Files
  6. If you don't have any files you need to add them. If you are using the simulator the easiest way to add is to open Safary in a media file and then share it to PocketCasts
  7. Tap on the file
  8. Tap on the edit option and check if you see: userFileEditShown event on the console
  9. Tap on cancel and check if you see: userFileEditDismissed event on the console
  10. Tap on the edit gain option and check if you see: userFileEditShown event on the console
  11. Now tap on Save and check if you see: userFileEditSave event on the console
  12. Tap on the file again
  13. Tap on delete and check if you see: userFileDeleteShown event on the console
  14. Dismiss by dragging the sheet down and check if you see: userFileDeleteDismissed event on the console

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the Analytics Analytics related issues label Jan 16, 2025
@SergioEstevao SergioEstevao added this to the 7.81 milestone Jan 16, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner January 16, 2025 14:40
@SergioEstevao SergioEstevao requested review from bjtitus and removed request for a team January 16, 2025 14:40
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao requested review from danielebogo and removed request for bjtitus January 16, 2025 14:41
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good:
🔵 Tracked: user_file_edit_shown
🔵 Tracked: user_file_edit_dismissed
🔵 Tracked: user_file_edit_save
🔵 Tracked: user_file_delete_shown
🔵 Tracked: user_file_delete_dismissed

:shipit:

@SergioEstevao SergioEstevao merged commit f7133f8 into trunk Jan 17, 2025
5 of 7 checks passed
@SergioEstevao SergioEstevao deleted the track_audit/add_missing_user_files_events branch January 17, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Analytics related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing User File Details View missing events
3 participants