Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(content-distribution): better readability for ignored attributes #204

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

miguelpeixe
Copy link
Member

Update the wording of reserved post meta and taxonomies to ignored. It also updates docblocks so the behavior of post meta sync is more clear.

Testing

There should be no functional changes. Unit tests should pass and distribution should work as expected.

@miguelpeixe miguelpeixe requested a review from naxoc January 28, 2025 14:49
@miguelpeixe miguelpeixe self-assigned this Jan 28, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner January 28, 2025 14:50
Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a ton of sense. Thanks! 🙏

@miguelpeixe miguelpeixe merged commit 22240db into trunk Jan 28, 2025
4 checks passed
@miguelpeixe miguelpeixe deleted the chore/content-distribution-ignored-meta-tax branch January 28, 2025 14:55
Copy link

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants