-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carousel): rename block and reorganise settings #1962
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a little updating to more closely match changes made in #2000:
- Rename "Settings" panel to "Display"
- Rename "Loop" panel to "Content"
- Move "Display" panel below "Content" panel
These changes would bring the sidebar panels more in line with changes to the Content Loop block in #2000.
Aside from that, there are some additional changes we could consider to this block, either in this PR or another one. Consider these non-blocking suggestions rather than required changes.
- Add option to "Allow duplicate stories" or not, and make sure it works the same way in both editor vs. front-end (see comment for details on how it's currently slightly broken)
- Consider moving attributes from
index.js
to ablock.json
file for registering block attributes, to bring it in line with other blocks in our codebase
All Submissions:
Changes proposed in this Pull Request:
Similar to #1943, this time for the "Post Carousel" block.
How to test the changes in this Pull Request:
Other information: