Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): rename block and reorganise settings #1962

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Similar to #1943, this time for the "Post Carousel" block.

How to test the changes in this Pull Request:

  1. Add a bunch of Carousel Post blocks to a page with various settings
  2. Switch to this branch
  3. Check if the blocks are still displaying the correct information and has kept the correct settings

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot changed the title Update/reorganise post carousel feat©rousel): rename block and reorganise settings Nov 15, 2024
@thomasguillot thomasguillot changed the title feat©rousel): rename block and reorganise settings feat(carousel): rename block and reorganise settings Nov 15, 2024
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a little updating to more closely match changes made in #2000:

  • Rename "Settings" panel to "Display"
  • Rename "Loop" panel to "Content"
  • Move "Display" panel below "Content" panel

These changes would bring the sidebar panels more in line with changes to the Content Loop block in #2000.

Aside from that, there are some additional changes we could consider to this block, either in this PR or another one. Consider these non-blocking suggestions rather than required changes.

  • Add option to "Allow duplicate stories" or not, and make sure it works the same way in both editor vs. front-end (see comment for details on how it's currently slightly broken)
  • Consider moving attributes from index.js to a block.json file for registering block attributes, to bring it in line with other blocks in our codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants