Bellatrix playwright upgrade #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppedBrowserCreateService
Implemented methods that can be implemented, and made [Obsolete] methods that cannot be implemented.
+ In this wrapper called WebElement, the conversion from async to sync is implemented, rendering such conversion unnecessary in other parts of the module + WebElement has a logic to switch between ILocator and IFrameLocator + Components of type Frame exclusively mark their Wrapped WebElement as 'iframe'
…ext, IPage, and IBrowserType The wrappers convert async to sync code
…d in BrowserPage as well + added to the MapperConfiguration maps for converting the options to page options
… sync conversion logic in a single place
… because of vulnerabilities
…omateThePlanet/BELLATRIX into bellatrix-playwright-upgrade
MiriamKyoseva
requested review from
angelovstanton
and removed request for
angelovstanton
teo-nikolov
previously approved these changes
Apr 18, 2024
MiriamKyoseva
requested review from
teo-nikolov
and removed request for
angelovstanton
teo-nikolov
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.