Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique File Tags #7

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Unique File Tags #7

merged 2 commits into from
Jan 29, 2024

Conversation

FG-TUM
Copy link
Member

@FG-TUM FG-TUM commented Jan 29, 2024

Problem

Tags are stored in arrays and can thus be non-unique. This is ugly in the output.

Solution

  • Implement a uniqueFilter for Arrays.
  • Apply filter after extraction and after collecting tags recursively.
  • Tests for the above.

Why not Set

Set (currently?) has a less impressive interface and would require more changes.

@FG-TUM FG-TUM self-assigned this Jan 29, 2024
@FG-TUM FG-TUM merged commit 1cc6cba into main Jan 29, 2024
15 checks passed
@FG-TUM FG-TUM deleted the makeTagsUnique branch January 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FG-TUM FG-TUM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FG-TUM