Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Version #5

Merged
merged 75 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
2fe7f48
update metadata
FG-TUM Dec 28, 2023
9dcc30e
input parsing
FG-TUM Dec 28, 2023
0f20758
remove default tests and add simply dummy test
FG-TUM Dec 31, 2023
07da1bf
update dependencies
FG-TUM Jan 15, 2024
bacaa2b
some test version
FG-TUM Jan 15, 2024
e5464c8
debug messages
FG-TUM Jan 15, 2024
f913ba7
debug messages
FG-TUM Jan 15, 2024
74baf2d
debug messages
FG-TUM Jan 15, 2024
914d200
js -> ts
FG-TUM Jan 18, 2024
fbc3eec
undefined guards
FG-TUM Jan 18, 2024
b39146a
remove debug output
FG-TUM Jan 18, 2024
1ca44bd
ts -> js
FG-TUM Jan 18, 2024
e4bee97
50/50
FG-TUM Jan 18, 2024
0f05e1b
implement rough core logic
FG-TUM Jan 18, 2024
a0c1668
fix path cropping
FG-TUM Jan 18, 2024
9a6a334
fix naming comparison
FG-TUM Jan 18, 2024
b2c6b7e
fix naming comparison and logic error
FG-TUM Jan 18, 2024
2d6d0f6
missing basename
FG-TUM Jan 18, 2024
7baef5f
remove unused basebranch
FG-TUM Jan 18, 2024
ca04bb7
doc
FG-TUM Jan 18, 2024
19a78c9
move findFileByName to utils
FG-TUM Jan 21, 2024
db371f9
add tests for new utils
FG-TUM Jan 21, 2024
3c7d65e
Remove unused argument
FG-TUM Jan 21, 2024
1c85fd9
checkDocumentation now returns messages + first test on comments
FG-TUM Jan 22, 2024
3579eb4
run npm
FG-TUM Jan 22, 2024
73656bf
renaming and todo
FG-TUM Jan 22, 2024
ad36c58
fancier formatting of the message
FG-TUM Jan 22, 2024
8ea8835
add missing linebreak
FG-TUM Jan 22, 2024
a255963
debug output
FG-TUM Jan 22, 2024
a929b0e
some headings
FG-TUM Jan 22, 2024
7405351
carefully select which comment to delete
FG-TUM Jan 22, 2024
7ffc5a7
.
FG-TUM Jan 22, 2024
e16e2ff
This is where it all begins...
FG-TUM Jan 22, 2024
0e02a36
Convert console logs to gh logs + doc
FG-TUM Jan 22, 2024
3eac27e
extract buildMessage
FG-TUM Jan 22, 2024
2bf2456
doc, cleanup
FG-TUM Jan 22, 2024
aef9661
lgtm message
FG-TUM Jan 22, 2024
a70850e
klickable file names
FG-TUM Jan 22, 2024
8a9359c
I'm hungry
FG-TUM Jan 22, 2024
0857b37
pep8 fixer
FG-TUM Jan 22, 2024
64e892f
Oh my god what year is it?!
FG-TUM Jan 22, 2024
e2d7448
Please forgive me
FG-TUM Jan 22, 2024
0cadd3f
Landed.
FG-TUM Jan 22, 2024
4387e40
Now we tell you your browser sucks in your native tongue.
FG-TUM Jan 22, 2024
1129605
undo experiment
FG-TUM Jan 22, 2024
ae13437
beatification
FG-TUM Jan 22, 2024
21893dc
const
FG-TUM Jan 23, 2024
0552cbb
first version of README
FG-TUM Jan 23, 2024
b9f7668
remove unused var
FG-TUM Jan 23, 2024
8b9e379
extract extraction functionality into functions + fix tag extraction …
FG-TUM Jan 23, 2024
847b3a9
recursion
FG-TUM Jan 23, 2024
878089e
remove unused code from the template
FG-TUM Jan 23, 2024
5ebf224
typo
FG-TUM Jan 23, 2024
675b96a
update
FG-TUM Jan 23, 2024
f097290
badge test
FG-TUM Jan 23, 2024
8046806
assertNonNull utility
FG-TUM Jan 23, 2024
386586a
doc, for..do instead of forEach
FG-TUM Jan 23, 2024
bb97d78
use assertNonNull
FG-TUM Jan 23, 2024
f97d7f4
first context dependent test
FG-TUM Jan 23, 2024
7362a20
added missing utils tests
FG-TUM Jan 23, 2024
69aa8af
crude outline of integration test
FG-TUM Jan 24, 2024
ac33f69
remove not applicable ci test
FG-TUM Jan 24, 2024
8ab5c99
comments
FG-TUM Jan 24, 2024
fdd9565
typo
FG-TUM Jan 24, 2024
e8c0a84
fix markdown linting
FG-TUM Jan 24, 2024
631dbe6
more linter fixes
FG-TUM Jan 24, 2024
1da14f3
Remove duplicate empty line
FG-TUM Jan 24, 2024
fa42340
many expectations to run, recursive option, docFileExtension option
FG-TUM Jan 24, 2024
88098e3
remove shallow copy
FG-TUM Jan 24, 2024
258a04b
optional arguments
FG-TUM Jan 24, 2024
3844155
formatting
FG-TUM Jan 24, 2024
66351fa
all zeh expectations
FG-TUM Jan 24, 2024
7f043e7
files for file discovery
FG-TUM Jan 24, 2024
c5b2de7
don't lint testData
FG-TUM Jan 24, 2024
2593ec6
document optional inputs
FG-TUM Jan 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/linters/.markdown-lint.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Unordered list style
# All items in unordered lists should start with '-'
MD004:
style: dash

# Ordered list item prefix
# Disable line limits
MD013: false

# All items in ordered list should be numbered as '1.'
MD029:
style: one
18 changes: 0 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,3 @@ jobs:
id: npm-ci-test
run: npm run ci-test

test-action:
name: GitHub Actions Test
runs-on: ubuntu-latest

steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

- name: Test Local Action
id: test-action
uses: ./
with:
milliseconds: 2000

- name: Print Output
id: output
run: echo "${{ steps.test-action.outputs.time }}"
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
uses: super-linter/super-linter/slim@v5
env:
DEFAULT_BRANCH: main
FILTER_REGEX_EXCLUDE: dist/**/*
FILTER_REGEX_EXCLUDE: (dist|__tests__/testData)/**/*
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TYPESCRIPT_DEFAULT_STYLE: prettier
VALIDATE_ALL_CODEBASE: true
Expand Down
2 changes: 0 additions & 2 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
# Repository CODEOWNERS

* @actions/actions-runtime
* @ncalteen
264 changes: 59 additions & 205 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,230 +1,84 @@
# Create a GitHub Action Using TypeScript
# DocTagChecker

[![GitHub Super-Linter](https://github.com/actions/typescript-action/actions/workflows/linter.yml/badge.svg)](https://github.com/super-linter/super-linter)
![CI](https://github.com/actions/typescript-action/actions/workflows/ci.yml/badge.svg)
[![Check dist/](https://github.com/actions/typescript-action/actions/workflows/check-dist.yml/badge.svg)](https://github.com/actions/typescript-action/actions/workflows/check-dist.yml)
[![CodeQL](https://github.com/actions/typescript-action/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/actions/typescript-action/actions/workflows/codeql-analysis.yml)
[![GitHub Super-Linter](https://github.com/AutoPas/DocTagChecker/actions/workflows/linter.yml/badge.svg)](https://github.com/super-linter/super-linter)
![CI](https://github.com/AutoPas/DocTagChecker/actions/workflows/ci.yml/badge.svg)
[![Check dist/](https://github.com/AutoPas/DocTagChecker/actions/workflows/check-dist.yml/badge.svg)](https://github.com/AutoPas/DocTagChecker/actions/workflows/check-dist.yml)
[![CodeQL](https://github.com/AutoPas/DocTagChecker/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/AutoPas/DocTagChecker/actions/workflows/codeql-analysis.yml)
[![Coverage](./badges/coverage.svg)](./badges/coverage.svg)

Use this template to bootstrap the creation of a TypeScript action. :rocket:
An GitHub action to help you keep your user documentation up to date with your source code.

This template includes compilation support, tests, a validation workflow,
publishing, and versioning guidance.
It works by looking for file or directory tags in your documentation and then checking if these documentation pages are changed if the linked source code is updated.
Since this is very prone to false-positives it does never fail workflows but instead post status comments to the corresponding pull request.

If you are new, there's also a simpler introduction in the
[Hello world JavaScript action repository](https://github.com/actions/hello-world-javascript-action).

## Create Your Own Action

To create your own action, you can use this repository as a template! Just
follow the below instructions:

1. Click the **Use this template** button at the top of the repository
1. Select **Create a new repository**
1. Select an owner and name for your new repository
1. Click **Create repository**
1. Clone your new repository

> [!IMPORTANT]
>
> Make sure to remove or update the [`CODEOWNERS`](./CODEOWNERS) file! For
> details on how to use this file, see
> [About code owners](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners).

## Initial Setup

After you've cloned the repository to your local machine or codespace, you'll
need to perform some initial setup steps before you can develop your action.

> [!NOTE]
>
> You'll need to have a reasonably modern version of
> [Node.js](https://nodejs.org) handy (20.x or later should work!). If you are
> using a version manager like [`nodenv`](https://github.com/nodenv/nodenv) or
> [`nvm`](https://github.com/nvm-sh/nvm), this template has a `.node-version`
> file at the root of the repository that will be used to automatically switch
> to the correct version when you `cd` into the repository. Additionally, this
> `.node-version` file is used by GitHub Actions in any `actions/setup-node`
> actions.

1. :hammer_and_wrench: Install the dependencies

```bash
npm install
```

1. :building_construction: Package the TypeScript for distribution

```bash
npm run bundle
```

1. :white_check_mark: Run the tests

```bash
$ npm test

PASS ./index.test.js
✓ throws invalid number (3ms)
✓ wait 500 ms (504ms)
✓ test runs (95ms)

...
```

## Update the Action Metadata

The [`action.yml`](action.yml) file defines metadata about your action, such as
input(s) and output(s). For details about this file, see
[Metadata syntax for GitHub Actions](https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions).

When you copy this repository, update `action.yml` with the name, description,
inputs, and outputs for your action.

## Update the Action Code

The [`src/`](./src/) directory is the heart of your action! This contains the
source code that will be run when your action is invoked. You can replace the
contents of this directory with your own code.

There are a few things to keep in mind when writing your action code:

- Most GitHub Actions toolkit and CI/CD operations are processed asynchronously.
In `main.ts`, you will see that the action is run in an `async` function.

```javascript
import * as core from '@actions/core'
//...

async function run() {
try {
//...
} catch (error) {
core.setFailed(error.message)
}
}
```

For more information about the GitHub Actions toolkit, see the
[documentation](https://github.com/actions/toolkit/blob/master/README.md).

So, what are you waiting for? Go ahead and start customizing your action!

1. Create a new branch
## Usage

```bash
git checkout -b releases/v1
```
To use DocTagChecker in your project, you need to include it and adhere to its (very few) assumptions.

1. Replace the contents of `src/` with your action code
1. Add tests to `__tests__/` for your source code
1. Format, test, and build the action
### Add DocTagChecker to your Workflows

```bash
npm run all
```
To add this action to your CI copy and adapt the following into your `YAML` workflow file.

> [!WARNING]
>
> This step is important! It will run [`ncc`](https://github.com/vercel/ncc)
> to build the final JavaScript action code with all dependencies included.
> If you do not run this step, your action will not work correctly when it is
> used in a workflow. This step also includes the `--license` option for
> `ncc`, which will create a license file for all of the production node
> modules used in your project.
```yaml
jobs:
DocTagCheck:
steps:
- name: Checkout your code
uses: your/way/to/checkout
- name: Check for missing userdoc updates
uses: AutoPas/DocTagChecker@main # substitute main for a release tag
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
# multiple paths are separated by whitespace or ','
userDocsDirs: paths/to/ your/doc/dir relative/to/repo/root
# Optional inputs with defaults:
# Check userDocsDirs recursively.
recurseUserDocDirs: false
# File extensions for files to be considered documentation.
docFileExtensions: md
# File extensions for files to be considered source code.
srcFileExtensions: cpp h txt
```

1. Commit your changes
### Tag your Documentation

```bash
git add .
git commit -m "My first action is ready!"
```
DocTagChecker looks for two kinds of tags in all documentation files:

1. Push them to your repository
- **File Tags**: Any filename that occurs in the file. A filename is a string without white spaces that ends with a file ending. File tags do not include paths.
- **Directory Tags**: Any path that occurs after the string "Related Files and Folders", so it is advised to create such a section at the end of every documentation page. A path is a string without white spaces that ends with a `/`. It can be absolute or relative to the root of the repository. Everything in the tagged directory will be recursively added to the file tags.

```bash
git push -u origin releases/v1
```
## Build and Develop

1. Create a pull request and get feedback on your action
1. Merge the pull request into the `main` branch
This GitHub action was created from the [actions/typescrip-action template](https://github.com/actions/typescript-action). Refer to this for general tips, techniques, and guidelines.

Your action is now published! :rocket:
### Dependencies

For information about versioning your action, see
[Versioning](https://github.com/actions/toolkit/blob/master/docs/action-versioning.md)
in the GitHub Actions toolkit.
- [Node.js](https://nodejs.org) Version >= 20

## Validate the Action
### Development Workflow

You can now validate the action by referencing it in a workflow file. For
example, [`ci.yml`](./.github/workflows/ci.yml) demonstrates how to reference an
action in the same repository.
The general development workflow should look as follows:

```yaml
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

- name: Test Local Action
id: test-action
uses: ./
with:
milliseconds: 1000

- name: Print Output
id: output
run: echo "${{ steps.test-action.outputs.time }}"
```
1. Create a new branch for your update

For example workflow runs, check out the
[Actions tab](https://github.com/actions/typescript-action/actions)! :rocket:
```bash
git checkout -b myAwsomeUpdate
```

## Usage
1. Implement your update in [`src/`](src) in TypeScript.

After testing, you can create version tag(s) that developers can use to
reference different stable versions of your action. For more information, see
[Versioning](https://github.com/actions/toolkit/blob/master/docs/action-versioning.md)
in the GitHub Actions toolkit.
If you need new input values for the action, add them to [`action.yml`](action.yml)
1. Add tests to [`__tests__`](__tests__).
1. Format, build, and run the tests.

To include the action in a workflow in another repository, you can use the
`uses` syntax with the `@` symbol to reference a specific branch, tag, or commit
hash.
```bash
npm run all
```

```yaml
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

- name: Test Local Action
id: test-action
uses: actions/typescript-action@v1 # Commit with the `v1` tag
with:
milliseconds: 1000

- name: Print Output
id: output
run: echo "${{ steps.test-action.outputs.time }}"
```
This is critical. Without this step the JavaScript code, which is what's actually run, is not built and nothing changes!
1. Commit, push, review, merge to main.
1. (If applicable) Create a new release using the [release script](script/release).

## Publishing a new release

This project includes a helper script designed to streamline the process of
tagging and pushing new releases for GitHub Actions.

GitHub Actions allows users to select a specific version of the action to use,
based on release tags. Our script simplifies this process by performing the
following steps:

1. **Retrieving the latest release tag:** The script starts by fetching the most
recent release tag by looking at the local data available in your repository.
1. **Prompting for a new release tag:** The user is then prompted to enter a new
release tag. To assist with this, the script displays the latest release tag
and provides a regular expression to validate the format of the new tag.
1. **Tagging the new release:** Once a valid new tag is entered, the script tags
the new release.
1. **Pushing the new tag to the remote:** Finally, the script pushes the new tag
to the remote repository. From here, you will need to create a new release in
GitHub and users can easily reference the new tag in their workflows.
```bash
script/release
```
Loading
Loading