Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfiles #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update dockerfiles #7

wants to merge 1 commit into from

Conversation

pazara18
Copy link
Contributor

I've updated the base and gcc dockerfiles and the documentation for the migration from C/Python API to pybind11.

I have added the gcc Dockerfile only for reference. Ideally, you would publish the image autopas/build-base image on Dockerhub and all dockerfiles which inherit it (archer, clang, code-coverage, doxygen, gcc) should have pybind11 and nlohmann-json3-dev installed without adding those lines since they inherit from that image.

If you wouldn't want to include these packages in the README for these dockerfiles, please delete the lines I've added.

@pazara18 pazara18 requested a review from SamNewcome December 16, 2024 21:13
Copy link
Member

@SteffenSeckler SteffenSeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi: if the Json parsing is performance relevant, it's likely better to not use the nlohman json parser. See also this discussion: https://www.reddit.com/r/cpp/s/9bEsfCrqeo

Though I suspect that the Json parsing isn't performance relevant...

@pazara18
Copy link
Contributor Author

pazara18 commented Dec 17, 2024

From what I've noticed, the parser doesn't introduce any noticable performance issues, probably because the JSONs used are very small. I could go back to a substring-search based approach instead of a parser but this is more elegant and could be useful in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants