Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timelapse chart throwing an error #106

Conversation

StefanVanDyck
Copy link
Contributor

When trying to play the timelapse chart in regions we were getting an error dialog box.
This was caused by the SOLR range query containing unencoded square brackets.
Simply making sure that part of the query is also encoded should fix things.

@StefanVanDyck StefanVanDyck force-pushed the inbo/vlaams-biodiversiteitsportaal-26-fix-error-when-showing-timelapse branch from f1ef58c to 0879e66 Compare September 10, 2024 14:49
@StefanVanDyck
Copy link
Contributor Author

I think with the last commit, I finally got most of the places that were missing urlencoding for the request parameters.

@adam-collins adam-collins self-assigned this Sep 24, 2024
@adam-collins
Copy link
Contributor

I failed to reproduce the url encode errors. More details to reproduce are required.

I did find various time control issues, see #107.

@StefanVanDyck
Copy link
Contributor Author

Thanks for having a look @adam-collins .

I suspect the reason I was having issues is that I am using AWS ALB as reverse proxy.
And that things like nginx and grails itself actually have no issue with square brackets in the URI.

According to the standard square brackets are not supported however and including this "fix" might help other people that encounter similar issues.

I'll make sure to merge the improvements you made on #107 into this branch.

Please tell me f you would like me to make any other changes or add some testing before accepting the PR.

@adam-collins adam-collins self-requested a review October 30, 2024 23:21
@adam-collins adam-collins added this to the 4.1.0 milestone Oct 30, 2024
Copy link
Contributor

@adam-collins adam-collins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found.

I failed to replicate the issue but additional encoding is always good.

@adam-collins adam-collins merged commit f6a3f98 into AtlasOfLivingAustralia:develop Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants