-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timelapse chart throwing an error #106
Fix timelapse chart throwing an error #106
Conversation
f1ef58c
to
0879e66
Compare
I think with the last commit, I finally got most of the places that were missing urlencoding for the request parameters. |
I failed to reproduce the url encode errors. More details to reproduce are required. I did find various time control issues, see #107. |
Thanks for having a look @adam-collins . I suspect the reason I was having issues is that I am using AWS ALB as reverse proxy. According to the standard square brackets are not supported however and including this "fix" might help other people that encounter similar issues. I'll make sure to merge the improvements you made on #107 into this branch. Please tell me f you would like me to make any other changes or add some testing before accepting the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found.
I failed to replicate the issue but additional encoding is always good.
When trying to play the timelapse chart in regions we were getting an error dialog box.
This was caused by the SOLR range query containing unencoded square brackets.
Simply making sure that part of the query is also encoded should fix things.