Merge pull request #197 from AthennaIO/develop

Handle non-object errors

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/core",
-  "version": "4.12.0",
+  "version": "4.13.0",
   "description": "The plug and play Node.js framework.",
   "license": "MIT",
   "author": "João Lenon <[email protected]>",

src/ignite/Ignite.ts

@@ -448,7 +448,7 @@ export class Ignite {
    * Handle an error turning it pretty and logging as fatal.
    */
   public async handleError(error: any) {
-    if (process.versions.bun) {
+    if (process.versions.bun || (!Is.Error(error) && !Is.Exception(error))) {
       console.error(error)
 
       /**

tests/unit/ignite/IgniteTest.ts

@@ -453,6 +453,29 @@ export default class IgniteTest {
     assert.notCalled(fatalMock)
   }
 
+  @Test()
+  public async shouldCatchErrorsThatAreNotVanillaErrorsOrExceptions({ assert }: Context) {
+    process.versions.bun = '1.0.0'
+    const fatalMock = Mock.fake()
+    Log.when('channelOrVanilla').return({
+      fatal: fatalMock
+    })
+    Mock.when(process.stderr, 'write').return(undefined)
+    Mock.when(process, 'exit').return(undefined)
+
+    const ignite = new Ignite()
+
+    Mock.spy(ignite, 'handleError')
+    Mock.when(ignite, 'setUncaughtExceptionHandler').throw('error')
+
+    await ignite.load(Path.toHref(Path.pwd() + '/'))
+
+    assert.calledOnce(process.stderr.write)
+    assert.calledWith(process.exit, 1)
+    assert.calledOnce(ignite.handleError)
+    assert.notCalled(fatalMock)
+  }
+
   @Test()
   public async shouldBeAbleToLoadAnEnvFileWhenFiringAthennaApplication({ assert }: Context) {
     const ignite = await new Ignite().load(Path.toHref(Path.pwd() + '/'), {