Initial Qt6 port #53
Draft
Initial Qt6 port #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a typo in all the existing docs.
|
Oh nice! This is a very welcome step 😄 do you have broader plans regarding Qt6 adoption in Asteroid or was that a one-off experiment ? And if so, is there any way we could help or support you with that ? |
|
I do want to get all of the AsteroidOS UI and apps running on top of Qt6 with Halium/libhybris yes, but we'll see how large this ends up being as yet another project I've decided to undertake for some reason 🤣 |
This comment was marked as outdated.
This comment was marked as outdated.
It's a POSIX sh script as indicated by its shebang.
src/controls/CMakeLists.txt already makes use of the following: https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#list-transformations
To fix the following observed build warning:
src/app/asteroidapp.cpp:80:13: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
80 | translator->load(QLocale(), appName(), ".", "/usr/share/translations", ".qm");
| ^~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re-use the already existing listing of controls used for documentation generation as well. WIP because this will be replaced by qt_add_qml_module()
Fixes runtime warnings such as:
qt.qml.context: qrc:/org/asteroid/controls/qml/BorderGestureArea.qml:160:5 Parameter "mouse" is not declared. Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.
As an alternative the following also would work:
function onPressed(mouse) { ... }
This doesn't work on Chimera Linux which uses the FreeBSD grep(1); adds a new build-time dependency on xmllint which I'm not sure how to feel about yet.
It's worth revisiting if this makes sense to keep as a dependency with some repeatable benchmarks where a quantifiable difference may or may not be observed when running this on a watch. If this is to be removed cmake/FindMapplauncherd_qt*.cmake additionally should also be gone.
Let's adopt QTP0001 already and move all per-application resources under qrc:/qt/qml/AsteroidApp/
This one (for now at least) retains the manually written plugin instead
of generating one since it also changes the default font instead of just
calling qmlRegisterType for each C++ QML component:
QGuiApplication::setFont(QFont("Noto Sans"));
If another way to accomplish the same task globally for anything using
org.asteroid.controls is found the same as one commit above for
org.asteroid.utils can also be done here and controls_plugin.* can be
done away with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds as tested on Qt 6.8.0. Current status:
asteroid-calculatorwith patches runs!My AsteroidOS package integration work for Chimera Linux which this PR is a part of along with all other patches can be found at https://github.com/JamiKettunen/cports/commits/hybris/; I'll likely update this description when I have more stuff of interest to share..