Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project setup and CI #21

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

mickvangelderen
Copy link
Contributor

@mickvangelderen mickvangelderen commented Jan 10, 2025

Add ruff and pyright configuration
Move dev dependencies from optional dependencies to development dependencies section
Fix some lints
Remove working-directory key from action steps so config gets picked up
Ensure only the necessary packages are installed by uv by issuing uv sync before each unit test group

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 94.20290% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.68%. Comparing base (eb1e8e0) to head (569bc5f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/jax_loop_utils/metric_writers/async_writer.py 50.00% 2 Missing ⚠️
...p_utils/metric_writers/torch/tensorboard_writer.py 33.33% 2 Missing ⚠️
src/jax_loop_utils/internal/flax/struct.py 75.00% 1 Missing ⚠️
...jax_loop_utils/metric_writers/tf/summary_writer.py 0.00% 1 Missing ⚠️
src/jax_loop_utils/parameter_overview.py 90.00% 1 Missing ⚠️
src/jax_loop_utils/periodic_actions.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   93.69%   93.68%   -0.02%     
==========================================
  Files          45       45              
  Lines        2728     2723       -5     
==========================================
- Hits         2556     2551       -5     
  Misses        172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickvangelderen mickvangelderen force-pushed the mick/improve-project-setup-and-ci branch 3 times, most recently from 326cf9a to 54bf42e Compare January 10, 2025 22:43
Add ruff and pyright configuration
Move dev dependencies from optional dependencies to development
dependencies section
Fix some lints
@mickvangelderen mickvangelderen force-pushed the mick/improve-project-setup-and-ci branch from 54bf42e to c13b323 Compare January 10, 2025 22:46
@mickvangelderen mickvangelderen changed the title WIP Improve project setup and CI Jan 10, 2025
@mickvangelderen mickvangelderen marked this pull request as ready for review January 10, 2025 22:46
Copy link
Member

@garymm garymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/checks.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mickvangelderen mickvangelderen merged commit 2670570 into master Jan 13, 2025
5 checks passed
@mickvangelderen mickvangelderen deleted the mick/improve-project-setup-and-ci branch January 13, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants