Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mlflow metric writer #12

Merged
merged 3 commits into from
Dec 12, 2024
Merged

add mlflow metric writer #12

merged 3 commits into from
Dec 12, 2024

Conversation

garymm
Copy link
Member

@garymm garymm commented Dec 10, 2024

No description provided.

Change-Id: Ief75dd77c24a63b05eec87b5b1f4822abb206abd
Change-Id: I650c7cfdaecc3da47df3ed1653790b97e84ee34f
@garymm garymm mentioned this pull request Dec 10, 2024
@garymm garymm changed the title add mlflow writer add mlflow metric writer Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 99.35484% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (02f0c34) to head (56536f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
..._utils/metric_writers/mlflow/metric_writer_test.py 99.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   92.44%   92.91%   +0.47%     
==========================================
  Files          32       35       +3     
  Lines        2090     2245     +155     
==========================================
+ Hits         1932     2086     +154     
- Misses        158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* rename class
* use list comprehension

Change-Id: I68fe00540b7805cf7b7f520d80333915735d34f2
@mickvangelderen mickvangelderen self-requested a review December 11, 2024 21:57
@garymm garymm merged commit 0c95f86 into master Dec 12, 2024
5 checks passed
@garymm garymm deleted the garymm/mlflow-writer branch December 12, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants