Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up code to eliminate compilation warnings #524

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Howard229
Copy link

@Howard229 Howard229 commented Aug 20, 2024

  1. Assign an initial value of 0 to the 'nSockets_base' variable to prevent the compilation warning 'may be used uninitialized in this function'.
  2. Delete the 'blockNum' variable, which is defined but not used in the 'polar_bulk_read_buffer_common' function.
  3. Delete the unused function definition 'px_show_scan_unit_size' from the 'guc_px.c' file. The implementation of this function has been removed in the d52e825 commit.

image

@polardb-bot
Copy link

polardb-bot bot commented Aug 20, 2024

Hi @Howard229 ~ Thanks for your contribution in this PR. ❤️

Please make sure that your PR conforms the standard, and has passed all the checks.

We will review your PR as soon as possible.

@polardb-bot
Copy link

polardb-bot bot commented Aug 20, 2024

Hey @Howard229 :

Something wrong occuried during the checks of your commit 😟, please check the detail:

⚠️ build_normal (ubuntu20.04, htap) View more details
⚠️ build_normal (ubuntu20.04, htap) View more details

@polardb-bot polardb-bot bot added the ci/failure CI status is failure label Aug 20, 2024
@polardb-bot
Copy link

polardb-bot bot commented Aug 20, 2024

Hey @Howard229 :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/failure CI status is failure labels Aug 20, 2024
@Howard229
Copy link
Author

Howard229 commented Aug 20, 2024

1、为nSockets_base变量赋初始值0,防止编译告警‘may be used uninitialized in this function’;
2、删除polar_bulk_read_buffer_common函数中定义但未使用的blockNum变量;
3、删除guc_px.c文件中多余的函数定义px_show_scan_unit_size,该函数的实现在d52e8258f4cfd4b6fc50d36d7149e9131a6581f3提交中已经被删除。

@Howard229
Copy link
Author

Hey @mrdrivingduck , could you help me review&merge it

@mrdrivingduck
Copy link
Member

mrdrivingduck commented Aug 21, 2024

@Howard229 better to edit your commit title and commit message to explain what you have changed. The code itself LGTM.

@Howard229
Copy link
Author

@Howard229 better to edit your commit title and commit message to explain what you have changed. The code itself LGTM.

Okay, I'll make some modifications

1. Assign an initial value of 0 to the 'nSockets_base' variable to
   prevent the compilation warning 'may be used uninitialized in this
   function'.
2. Delete the 'blockNum' variable, which is defined but not used in the
   'polar_bulk_read_buffer_common' function.
3. Delete the unused function definition 'px_show_scan_unit_size'
   from the 'guc_px.c' file. The implementation of this function has
   been removed in the d52e825 commit.
@Howard229 Howard229 changed the title Code Cleanup fix: clean up code to eliminate compilation warnings Aug 21, 2024
@polardb-bot
Copy link

polardb-bot bot commented Aug 21, 2024

Hey @Howard229 :

Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review.

@polardb-bot polardb-bot bot added ci/success CI status is success and removed ci/success CI status is success labels Aug 21, 2024
@Howard229
Copy link
Author

Howard229 commented Aug 21, 2024

@Howard229 better to edit your commit title and commit message to explain what you have changed. The code itself LGTM.

Hey @mrdrivingduck , I have updated the commit title and commit message. Could you please review them again?

@mrdrivingduck
Copy link
Member

/rebase-and-merge

@polardb-bot polardb-bot bot merged commit b7c1af0 into ApsaraDB:POLARDB_11_DEV Aug 21, 2024
14 checks passed
@polardb-bot
Copy link

polardb-bot bot commented Aug 21, 2024

@mrdrivingduck PR has been merged. 🍗

Thanks again for the contributors involved in this thread: ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/success CI status is success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants