Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NSAdvertisingAttributionReportEndpoint through Expo config #494

Closed
wants to merge 3 commits into from

Conversation

AdamGerthel
Copy link

I've just had to write my own expo plugin to add the NSAdvertisingAttributionReportEndpoint value to info.plist in a React Native project - and I figured I might as well attempt to get that into this package as I think it should be supported out of the box.

The PR is not 100% ready to go because I think there's questions that needs answering first:

  1. Should the endpoint URL be hardcoded to https://appsflyer-skadnetwork.com or should the value be provided via the plugin config?
  2. Should this be an optional configuration?

@amit-kremer93
Copy link
Contributor

@AdamGerthel thank you for this MR, but we are not going to add this soon

@AdamGerthel
Copy link
Author

Ok - then you could at least update the Expo installation documentation and add that they'll need to either write a custom expo config plugin or add the NSAdvertisingAttributionReportEndpoint value to ios.infoPlist in app.json.

@sprutner
Copy link
Contributor

@AdamGerthel I made #585 to update the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants