Use GHA, set minimal Ruby to 2.7, update dependencies #83
+26
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Dec 5, 2024
|
Thanks, @ekohl ! I've dropped rest-client complexity and using shared workflow now. Not sure why it didn't trigger unlike the previous one... |
ekohl
requested changes
Dec 9, 2024
|
Thanks, @ekohl, this indeed makes more sense, updated. |
ekohl
reviewed
Dec 9, 2024
|
GitHub doesn't trigger unknown actions. What I usually do is configure it to run on |
ofedoren
force-pushed
the
update-deps
branch
3 times, most recently
from
a77c556 to
a154bc4
Compare
ofedoren
force-pushed
the
update-deps
branch
from
a154bc4 to
7dc73ec
Compare
|
Thanks, @ekohl ! Seems green, worse case: we'll catch issues in hammer. |
ekohl
reviewed
Dec 10, 2024
ofedoren
force-pushed
the
update-deps
branch
from
7dc73ec to
867b0c8
Compare
ekohl
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT @ekohl and @adamruzicka ? I'd like to drop ancient relics, since the only usage of this lib known to me/rubygems is hammer-cli, which already requires Ruby 2.7 at least.