Line number support #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2014 10:15
Fixed wrong height of keyboard when the device is in landscape.
Added Line number support with implementation sourced from https://github.com/illyabusigin/CYRTextView and original implementation sourced from: https://github.com/alldritt/TextKit_LineNumbers
|
Nice, thank you! Two minor things in the demo project: If we're going with the default theme you might as well change the barStyle to default. And, even though the navigation-bar-title is redundant I think "Toggle Line Numbers" should be changed to something shorter. (Just "Line Numbers"?) In some way this PR set the default menlo font to nil in the example project, but it is fixed with cbb3b89. |
|
Might as well close this request because now that the build is mainly swift, changes are useless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added line number support for the issue #15 .
ruddfawcett recommended the https://github.com/illyabusigin/CYRTextView project which already has a good line number support.
I implemented the class which is responsible for the line numbers (
CYRLayoutManager).Line numbers can be enabled or disabled with the
drawLineNumbersproperty in theJLTextViewclass.The Colors of the line number column at the left side can be modified using the
JLGutterBackgroundColorandJLGutterLineColorkey in aJLTokenizerTheme.